Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754207Ab3IWVZL (ORCPT ); Mon, 23 Sep 2013 17:25:11 -0400 Received: from mail-ob0-f169.google.com ([209.85.214.169]:65349 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752809Ab3IWVZD (ORCPT ); Mon, 23 Sep 2013 17:25:03 -0400 MIME-Version: 1.0 In-Reply-To: <20130921235217.GB12132@localhost.localdomain> References: <20130920153400.GA32516@www.outflux.net> <20130921235217.GB12132@localhost.localdomain> Date: Mon, 23 Sep 2013 14:25:01 -0700 X-Google-Sender-Auth: 7YOTbVmWPz7Cz8N2YbPy-uGa5Jk Message-ID: Subject: Re: [PATCH RESEND] printk: report boot console names during cut-over From: Kees Cook To: Frederic Weisbecker Cc: LKML , Andrew Morton , Joe Perches , Tejun Heo , Greg Kroah-Hartman Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2502 Lines: 52 On Sat, Sep 21, 2013 at 4:52 PM, Frederic Weisbecker wrote: > On Fri, Sep 20, 2013 at 08:34:01AM -0700, Kees Cook wrote: >> This reports the names of boot consoles as they're being disabled to >> help identify which is which during cut-over. Helps answer the question >> "which boot console actually got activated?" once the regular console >> is running, mostly when debugging boot console failures. >> >> Signed-off-by: Kees Cook >> --- >> kernel/printk/printk.c | 16 ++++++++++------ >> 1 file changed, 10 insertions(+), 6 deletions(-) >> >> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c >> index b4e8500..0dc54c9 100644 >> --- a/kernel/printk/printk.c >> +++ b/kernel/printk/printk.c >> @@ -2361,14 +2361,18 @@ void register_console(struct console *newcon) >> if (bcon && >> ((newcon->flags & (CON_CONSDEV | CON_BOOT)) == CON_CONSDEV) && >> !keep_bootcon) { >> - /* we need to iterate through twice, to make sure we print >> - * everything out, before we unregister the console(s) >> + /* We need to iterate through all boot consoles, to make >> + * sure we print everything out, before we unregister them. >> */ >> - printk(KERN_INFO "console [%s%d] enabled, bootconsole disabled\n", >> - newcon->name, newcon->index); >> - for_each_console(bcon) >> - if (bcon->flags & CON_BOOT) >> + for_each_console(bcon) { >> + if (bcon->flags & CON_BOOT) { >> + printk(KERN_INFO "console [%s%d] enabled, " >> + "bootconsole [%s%d] disabled\n", >> + newcon->name, newcon->index, >> + bcon->name, bcon->index); >> unregister_console(bcon); > > Looks useful! But I think the "console %foo disabled" message should move to unregister_console() > instead. That way it also handles printk_late_init() and all other console unregisters. Yeah, that's a much cleaner way to do this. I'll send a new patch. Thanks! -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/