Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511Ab3IXMIT (ORCPT ); Tue, 24 Sep 2013 08:08:19 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:44726 "EHLO mail-ee0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823Ab3IXMIR (ORCPT ); Tue, 24 Sep 2013 08:08:17 -0400 Message-ID: <524180B7.7090307@gmail.com> Date: Tue, 24 Sep 2013 14:08:23 +0200 From: Jack Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: KY Srinivasan CC: Greg KH , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "ohering@suse.com" , "jbottomley@parallels.com" , "hch@infradead.org" , "linux-scsi@vger.kernel.org" , Mike Christie Subject: Re: Drivers: scsi: FLUSH timeout References: <1379705547-15028-1-git-send-email-kys@microsoft.com> <20130920203222.GA14306@kroah.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1811 Lines: 52 On 09/21/2013 07:24 AM, KY Srinivasan wrote: > > >> -----Original Message----- >> From: Greg KH [mailto:gregkh@linuxfoundation.org] >> Sent: Friday, September 20, 2013 1:32 PM >> To: KY Srinivasan >> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; >> ohering@suse.com; jbottomley@parallels.com; hch@infradead.org; linux- >> scsi@vger.kernel.org >> Subject: Re: Drivers: scsi: FLUSH timeout >> >> On Fri, Sep 20, 2013 at 12:32:27PM -0700, K. Y. Srinivasan wrote: >>> The SD_FLUSH_TIMEOUT value is currently hardcoded. >> >> Hardcoded where? Please, more context. > > This is defined in scsi/sd.h: > > #define SD_FLUSH_TIMEOUT (60 * HZ) >> >>> On our cloud, we sometimes hit this timeout. I was wondering if we >>> could make this a module parameter. If this is acceptable, I can send >>> you a patch for this. >> >> A module parameter don't make sense for a per-device value, does it? > Currently, the 60 second timeout is applied across devices. Ideally, I want to be > able to control the FLUSH TIMEOUT as we currently do I/O timeout. If this is > acceptable, I can work on a patch for that as well. > > Regards, > > K. Y >> >> greg k-h > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Hi, Back to 2010, Mike(cc-ed) try to add a flush time out interface, similar to what you want here, no idea why it's just ignored? http://www.spinics.net/lists/linux-scsi/msg45017.html Jack -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/