Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753674Ab3IXMnD (ORCPT ); Tue, 24 Sep 2013 08:43:03 -0400 Received: from mail-la0-f51.google.com ([209.85.215.51]:39487 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771Ab3IXMnA (ORCPT ); Tue, 24 Sep 2013 08:43:00 -0400 Message-ID: <1380026575.3371.1.camel@ThinkPad-X230.localdomain> Subject: Re: [PATCH v3 0/4] Fix Win8 backlight issue From: Igor Gnatenko To: Aaron Lu Cc: linux-acpi@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , "Rafael J. Wysocki" , Matthew Garrett , Seth Forshee , Lee Chun-Yi , Richard Purdie , Yves-Alexis Perez , Felipe Contreras , Henrique de Moraes Holschuh , Jani Nikula , Ben Jencks , Steven Newbury , James Hogan , Kamal Mostafa , Joerg Platte , Kalle Valo , Martin Steigerwald , =?ISO-8859-1?Q?J=F6rg?= Otte , Mike Galbraith Date: Tue, 24 Sep 2013 16:42:55 +0400 In-Reply-To: <1380016052-15315-1-git-send-email-aaron.lu@intel.com> References: <1380016052-15315-1-git-send-email-aaron.lu@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.9.92 (3.9.92-1.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2441 Lines: 59 On Tue, 2013-09-24 at 17:47 +0800, Aaron Lu wrote: > v3: > 1 Add a new patch 4/4 to fix some problems in thinkpad-acpi module; > 2 Remove unnecessary function acpi_video_unregister introduced in > patch 2/3 as pointed out by Jani Nikula. > > v2: > v1 has the subject of "Rework ACPI video driver" and is posted here: > http://lkml.org/lkml/2013/9/9/74 > Since the objective is really to fix Win8 backlight issues, I changed > the subject in this version, sorry about that. > > This patchset has three patches, the first introduced a new API named > backlight_device_registered in backlight layer that can be used for > backlight interface provider module to check if a specific type backlight > interface has been registered, see changelog for patch 1/3 for details. > Then patch 2/3 does the cleanup to sepeate the backlight control and > event delivery functionality in the ACPI video module and patch 3/3 > solves some Win8 backlight control problems by avoiding register ACPI > video's backlight interface if: > 1 Kernel cmdline option acpi_backlight=video is not given; > 2 This is a Win8 system; > 3 Native backlight control interface exists. > > Technically, patch 2/3 is not required to fix the issue here. So if you > think it is not necessary, I can remove it from the series. > > Aaron Lu (4): > backlight: introduce backlight_device_registered > ACPI / video: seperate backlight control and event interface > ACPI / video: Do not register backlight if win8 and native interface > exists > thinkpad-acpi: fix handle locate for video and query of _BCL > > drivers/acpi/internal.h | 5 +- > drivers/acpi/video.c | 442 ++++++++++++++++++++--------------- > drivers/acpi/video_detect.c | 14 +- > drivers/platform/x86/thinkpad_acpi.c | 31 ++- > drivers/video/backlight/backlight.c | 31 +++ > include/acpi/video.h | 2 + > include/linux/backlight.h | 4 + > 7 files changed, 324 insertions(+), 205 deletions(-) > Excellent! I've tested this patch-set on ThinkPad X230 and backlight issue is exhausted. Thanks. -- Igor Gnatenko Fedora release 20 (Heisenbug) Linux 3.11.1-300.fc20.x86_64 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/