Date: Tue, 24 Sep 2013 16:59:11 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Mike Travis <travis@sgi.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, Paul Mackerras <paulus@samba.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
        Jason Wessel <jason.wessel@windriver.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dimitri Sivanich <sivanich@sgi.com>, Hedi Berriche <hedi@sgi.com>,
        x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] x86/UV/KDB/NMI: Updates for NMI/KDB handler for SGI
 UV
Message-ID: <20130924145911.GA8494@gmail.com>
References: <20130923212459.544517569@asylum.americas.sgi.com>
 <20130924075212.GG28538@gmail.com>
 <524198FD.2090104@sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <524198FD.2090104@sgi.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 998
Lines: 33


* Mike Travis <travis@sgi.com> wrote:

> On 9/24/2013 12:52 AM, Ingo Molnar wrote:
> > 
> > Hm, do you test-build your patches? 
> 
> Both build and test incessantly...
> 
> This series produces the following
> > annoying warning:
> > 
> >  arch/x86/platform/uv/uv_nmi.c: In function ‘uv_nmi_setup’:
> >  arch/x86/platform/uv/uv_nmi.c:664:2: warning: the address of ‘uv_nmi_cpu_mask’ will always evaluate as ‘true’ [-Waddress]
> 
> I didn't hit the above warning since I never tried building without 
> CONFIG_CPUMASK_OFFSTACK defined. [...]

Ok, that explains it!

> [...]  I wonder if uv_nmi.c should not be built if not on an enterprise 
> sized system?

I don't think so - the config variations help root out such bugs.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/