Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754656Ab3IXQyw (ORCPT ); Tue, 24 Sep 2013 12:54:52 -0400 Received: from merlin.infradead.org ([205.233.59.134]:53324 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096Ab3IXQyu (ORCPT ); Tue, 24 Sep 2013 12:54:50 -0400 Date: Tue, 24 Sep 2013 18:54:37 +0200 From: Peter Zijlstra To: "Paul E. McKenney" Cc: Oleg Nesterov , Mel Gorman , Rik van Riel , Srikar Dronamraju , Ingo Molnar , Andrea Arcangeli , Johannes Weiner , Linux-MM , LKML , Thomas Gleixner , Steven Rostedt Subject: Re: [PATCH] hotplug: Optimize {get,put}_online_cpus() Message-ID: <20130924165437.GR9326@twins.programming.kicks-ass.net> References: <1378805550-29949-38-git-send-email-mgorman@suse.de> <20130917143003.GA29354@twins.programming.kicks-ass.net> <20130917162050.GK22421@suse.de> <20130917164505.GG12926@twins.programming.kicks-ass.net> <20130918154939.GZ26785@twins.programming.kicks-ass.net> <20130919143241.GB26785@twins.programming.kicks-ass.net> <20130923175052.GA20991@redhat.com> <20130924123821.GT12926@twins.programming.kicks-ass.net> <20130924160359.GA2739@redhat.com> <20130924164900.GG9093@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130924164900.GG9093@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 27 On Tue, Sep 24, 2013 at 09:49:00AM -0700, Paul E. McKenney wrote: > > > void cpu_hotplug_done(void) > > > { > > > + /* Signal the writer is done */ > > > + cpuhp_writer = 0; > > > + wake_up_all(&cpuhp_wq); > > > + > > > + /* Wait for any pending readers to be running */ > > > + cpuhp_writer_wait(!atomic_read(&cpuhp_waitcount)); > > > + cpuhp_writer_task = NULL; > > > > We also need to ensure that the next reader should see all changes > > done by the writer, iow this lacks "realease" semantics. > > Good point -- I was expecting wake_up_all() to provide the release > semantics, but code could be reordered into __wake_up()'s critical > section, especially in the case where there was nothing to wake > up, but where there were new readers starting concurrently with > cpu_hotplug_done(). Doh, indeed. I missed this in Oleg's email, but yes I made that same assumption about wake_up_all(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/