Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754329Ab3IXUAS (ORCPT ); Tue, 24 Sep 2013 16:00:18 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:43159 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753370Ab3IXUAR (ORCPT ); Tue, 24 Sep 2013 16:00:17 -0400 Date: Tue, 24 Sep 2013 22:59:58 +0300 From: Dan Carpenter To: Peter Senna Tschudin Cc: Alexander Holler , Bjorn Helgaas , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: checkpatch guide for newbies Message-ID: <20130924195958.GO6247@mwanda> References: <20130923090100.GE6192@mwanda> <5241CB44.8080004@ahsoftware.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 893 Lines: 29 On Tue, Sep 24, 2013 at 09:29:49PM +0200, Peter Senna Tschudin wrote: > I was about to disagree because I've never seen variables named a, b > or c, but I found that there are at least 2238 variables named a, b or > c in linux-next. This is not good. > In XGIfb_mode_rate_to_ddata() we have: int B, C, D, F, temp, j; The A and E variables were removed when the code was refactored. ;P Places like this are fairly rare in the kernel outside of the staging/ directory. There are lots of times where a single letter variable name is very natural. char c; C is terse. This is explained in Documentation/CodingStyle. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/