Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932215Ab3IYATK (ORCPT ); Tue, 24 Sep 2013 20:19:10 -0400 Received: from mail-ye0-f175.google.com ([209.85.213.175]:49464 "EHLO mail-ye0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754947Ab3IYATG (ORCPT ); Tue, 24 Sep 2013 20:19:06 -0400 Date: Tue, 24 Sep 2013 18:19:02 -0600 From: Bjorn Helgaas To: tianyu.lan@intel.com Cc: lenb@kernel.org, rjw@sisk.pl, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] PCI/ACPI: Convert ACPI PCI Hot Plug core debug fuction to dynamic debug function Message-ID: <20130925001902.GF9302@google.com> References: <1378783035-15681-1-git-send-email-tianyu.lan@intel.com> <1378783035-15681-2-git-send-email-tianyu.lan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378783035-15681-2-git-send-email-tianyu.lan@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 26 On Mon, Sep 09, 2013 at 11:17:15PM -0400, tianyu.lan@intel.com wrote: > From: Lan Tianyu > > This patch is to use pr_debug/info/warn/err to replace acpiphp debug > functions and remove module's debug param. > ... > /* local variables */ > @@ -61,9 +60,7 @@ static struct acpiphp_attention_info *attention_info; > MODULE_AUTHOR(DRIVER_AUTHOR); > MODULE_DESCRIPTION(DRIVER_DESC); > MODULE_LICENSE("GPL"); > -MODULE_PARM_DESC(debug, "Debugging mode enabled or not"); > MODULE_PARM_DESC(disable, "disable acpiphp driver"); > -module_param_named(debug, acpiphp_debug, bool, 0644); I have notes about booting with the "acpiphp.debug" parameter to turn on debugging. Can you tell me the way to do the equivalent with dynamic debug? I'll add that to the changelog before merging this. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/