Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758069Ab3IYBVz (ORCPT ); Tue, 24 Sep 2013 21:21:55 -0400 Received: from muin.pair.com ([209.68.1.55]:64768 "EHLO muin.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755162Ab3IYBVx (ORCPT ); Tue, 24 Sep 2013 21:21:53 -0400 MIME-Version: 1.0 In-Reply-To: <20130925110643.db5fa154bea3838ed6affa45@canb.auug.org.au> References: <20130925110643.db5fa154bea3838ed6affa45@canb.auug.org.au> Date: Tue, 24 Sep 2013 20:21:50 -0500 Message-ID: Subject: Re: linux-next: build failure after merge of the akpm tree From: Timur Tabi To: Stephen Rothwell Cc: Andrew Morton , Greg KH , lkml , Sergei Trofimovich , "linux-next@vger.kernel.org" , ppc-dev , Timur Tabi Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 38 On Tue, Sep 24, 2013 at 8:06 PM, Stephen Rothwell wrote: > Hi Andrew, > > After merging the akpm tree, linux-next builds (powerpc allmodconfig) > fail like this: > > drivers/tty/ehv_bytechan.c:362:1: error: type defaults to 'int' in declaration of 'console_initcall' [-Werror=implicit-int] > > Caused by commit 0f01cf96c2d4 ("./Makefile: enable -Werror=implicit-int > and -Werror=strict-prototypes by default") which has bee in linux-next > since Aug 16. This commit exposed that fact that > drivers/tty/ehv_bytechan.c can be built as a module, but has a > console_initcall (which is not available to modules). Is this something new? This code hasn't changed in over two years, so I'm surprised it suddenly broke. > This was > originally introduced in commit dcd83aaff1c8 ("tty/powerpc: introduce the > ePAPR embedded hypervisor byte channel driver") in v3.2. > > Anyone got a good solution? How about: #ifndef MODULE static int __init ehv_bc_console_init(void) { ... } console_initcall(ehv_bc_console_init); #endif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/