Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754793Ab3IYDLq (ORCPT ); Tue, 24 Sep 2013 23:11:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59085 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754502Ab3IYDLo (ORCPT ); Tue, 24 Sep 2013 23:11:44 -0400 Date: Tue, 24 Sep 2013 23:11:27 -0400 From: Dave Jones To: David Rientjes Cc: Andrew Morton , KOSAKI Motohiro , Chen Gang , Rik van Riel , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch] mm, mempolicy: make mpol_to_str robust and always succeed Message-ID: <20130925031127.GA4210@redhat.com> Mail-Followup-To: Dave Jones , David Rientjes , Andrew Morton , KOSAKI Motohiro , Chen Gang , Rik van Riel , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <5215639D.1080202@asianux.com> <5227CF48.5080700@asianux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 22 On Tue, Sep 24, 2013 at 07:58:22PM -0700, David Rientjes wrote: > case MPOL_BIND: > - /* Fall through */ > case MPOL_INTERLEAVE: > nodes = pol->v.nodes; > break; Any reason not to leave this ? "missing break" is the 2nd most common thing that coverity picks up. Most of them are false positives like the above, but the lack of annotations in our source makes it time-consuming to pick through them all to find the real bugs. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/