Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754902Ab3IYK2a (ORCPT ); Wed, 25 Sep 2013 06:28:30 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:37688 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832Ab3IYK23 (ORCPT ); Wed, 25 Sep 2013 06:28:29 -0400 Date: Wed, 25 Sep 2013 11:28:25 +0100 From: Lee Jones To: Sachin Kamat Cc: Wei Yongjun , "sameo@linux.intel.com" , yongjun_wei@trendmicro.com.cn, LKML Subject: Re: [PATCH] mfd: twl6040: drop devm_free_irq of devm_ allocated irq Message-ID: <20130925102825.GE5132@lee--X1> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 25 On Wed, 25 Sep 2013, Sachin Kamat wrote: > On 25 September 2013 13:07, Wei Yongjun wrote: > > From: Wei Yongjun > > > > - devm_free_irq(&client->dev, twl6040->irq_ready, twl6040); > > - devm_free_irq(&client->dev, twl6040->irq_th, twl6040); > > regmap_del_irq_chip(twl6040->irq, twl6040->irq_data); > > Now that the freeing of irq will happen after regmap_del_irq_chip, > wouldn't this cause any ordering related issues? I don't believe there is a requirement to free all associated IRQs before deleting an irqchip. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/