Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755095Ab3IYKgN (ORCPT ); Wed, 25 Sep 2013 06:36:13 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:11045 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754771Ab3IYKgL (ORCPT ); Wed, 25 Sep 2013 06:36:11 -0400 X-IronPort-AV: E=Sophos;i="4.90,977,1371052800"; d="scan'208";a="8617527" Message-ID: <5242BB6D.3060504@cn.fujitsu.com> Date: Wed, 25 Sep 2013 18:31:09 +0800 From: Gu Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: Toshi Kani CC: Tang Chen , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Yasuaki Ishimatsu Subject: Re: [Bug report] Warning when hot-add an ACPI0004 device. References: <52314A89.2060809@cn.fujitsu.com> <1378998712.12538.18.camel@misato.fc.hp.com> In-Reply-To: <1378998712.12538.18.camel@misato.fc.hp.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/09/25 18:34:25, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/09/25 18:34:26, Serialize complete at 2013/09/25 18:34:26 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4586 Lines: 105 Hi Toshi, On 09/12/2013 11:11 PM, Toshi Kani wrote: > On Thu, 2013-09-12 at 13:00 +0800, Tang Chen wrote: >> Hi Rafael, Toshi, >> >> When we hot-add an ACPI0004 device, we got the following warning: >> >> acpi ACPI0004:01: Attempt to re-insert >> >> The ACPI0004 device is a System Board in Fujitsu server, which has two >> numa nodes (processors and memory). >> >> It seems that we reserved the ACPI_NOTIFY_DEVICE_CHECK event twice in >> acpi_hotplug_notify_cb(). >> >> >> According to bisect, this happens after the following commit: >> >> From 68a67f6c78b80525d9b3c6672e7782de95e56a83 Mon Sep 17 00:00:00 2001 >> From: "Rafael J. Wysocki" >> Date: Sun, 3 Mar 2013 23:05:55 +0100 >> Subject: [PATCH 1/1] ACPI / container: Use common hotplug code >> >> Switch the ACPI container driver to using common device hotplug code >> introduced previously. This reduces the driver down to a trivial >> definition and registration of a struct acpi_scan_handler object. >> >> Signed-off-by: Rafael J. Wysocki >> Acked-by: Toshi Kani >> Tested-by: Toshi Kani >> --- >> drivers/acpi/container.c | 146 >> ++++------------------------------------------- >> 1 file changed, 10 insertions(+), 136 deletions(-) >> >> >> I'm now investigating this problem. If you have any idea about why this >> happens, please let me know. > > With the above change, container devices use the common notify handler, > which logs the warning message in question when it receives device check > twice on a same device. Before the change, the container-specific > notify handler did not log this message in the same case (but considered > it as an eject request). > > So, I suspect that you are getting device check twice regardless of the > kernel change. Can you check KERN_DEBUG messages to see if that is the > case? The notify handler logs all events with KERN_DEBUG. Follow your suggestion, we confirm that it really received ACPI_NOTIFY_ DEVICE_CHECK event*twice*, but the original ACPI container driver only received once, does the common device hotplug code introduce another device check? any idea? Container uses common device hotplug code: [ 142.937724] IPv6: ADDRCONF(NETDEV_CHANGE): eth8: link becomes ready [ 674.975575] ACPI: \_SB_.LSB1: ACPI_NOTIFY_DEVICE_CHECK event <<<< [ 674.991604] ACPI: \_SB_.LSB1: ACPI_NOTIFY_DEVICE_CHECK event <<<< [ 675.613990] ACPI: PCI Root Bridge [UNC2] (domain 0000 [bus fd]) [ 675.684970] acpi PNP0A03:01: ACPI _OSC support notification failed, disabling PCIe ASPM [ 675.780957] acpi PNP0A03:01: Unable to request _OSC control (_OSC support mask: 0x08) [ 675.874806] ACPI _OSC control for PCIe not granted, disabling ASPM [ 675.949005] pci_bus 0000:fd: Allocating resources [ 675.960145] ACPI: PCI Root Bridge [UNC3] (domain 0000 [bus fc]) [ 676.031176] acpi PNP0A03:02: ACPI _OSC support notification failed, disabling PCIe ASPM [ 676.127129] acpi PNP0A03:02: Unable to request _OSC control (_OSC support mask: 0x08) [ 676.220943] ACPI _OSC control for PCIe not granted, disabling ASPM [ 676.295019] pci_bus 0000:fc: Allocating resources Original ACPI container driver: [ 1526.122933] Container driver received ACPI_NOTIFY_DEVICE_CHECK event <<<< [ 1526.800646] ACPI: PCI Root Bridge [UNC2] (domain 0000 [bus fd]) [ 1526.871682] acpi PNP0A03:01: ACPI _OSC support notification failed, disabling PCIe ASPM [ 1526.967878] acpi PNP0A03:01: Unable to request _OSC control (_OSC support mask: 0x08) [ 1527.061891] ACPI _OSC control for PCIe not granted, disabling ASPM [ 1527.136036] pci_bus 0000:fd: Allocating resources [ 1527.150747] ACPI: PCI Root Bridge [UNC3] (domain 0000 [bus fc]) [ 1527.221821] acpi PNP0A03:02: ACPI _OSC support notification failed, disabling PCIe ASPM [ 1527.317738] acpi PNP0A03:02: Unable to request _OSC control (_OSC support mask: 0x08) [ 1527.411795] ACPI _OSC control for PCIe not granted, disabling ASPM [ 1527.485917] pci_bus 0000:fc: Allocating resources Thanks, Gu > > Thanks, > -Toshi > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/