Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755293Ab3IYL0y (ORCPT ); Wed, 25 Sep 2013 07:26:54 -0400 Received: from mail-ee0-f45.google.com ([74.125.83.45]:45698 "EHLO mail-ee0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755104Ab3IYL0x (ORCPT ); Wed, 25 Sep 2013 07:26:53 -0400 Date: Wed, 25 Sep 2013 13:26:29 +0200 From: Ingo Molnar To: Wei Yang Cc: linux-kernel@vger.kernel.org, acme@ghostprotocols.net, mingo@redhat.com Subject: Re: [PATCH] perf: fix two warning in bench/numa Message-ID: <20130925112629.GB29884@gmail.com> References: <1379839764-9245-1-git-send-email-weiyang@linux.vnet.ibm.com> <20130925073515.GA7053@weiyang.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130925073515.GA7053@weiyang.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 722 Lines: 27 * Wei Yang wrote: > Hi, all > > Any comments on this one? > > These two warnings will break the compile of perf under 32-bit machine. fix looks good to me. > >- if (diff.tv_sec >= g->p.nr_secs) { > >+ if (diff.tv_sec >= (time_t)g->p.nr_secs) { > >- printf(" #%2d / %2d: %14.2lf nsecs/op [val: %016lx]\n", > >+ printf(" #%2d / %2d: %14.2lf nsecs/op [val: %016"PRIu64"]\n", Acked-by: Ingo Molnar Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/