Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754801Ab3IYPut (ORCPT ); Wed, 25 Sep 2013 11:50:49 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:39102 "EHLO mail-pb0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753492Ab3IYPus (ORCPT ); Wed, 25 Sep 2013 11:50:48 -0400 Message-ID: <52430650.90300@gmail.com> Date: Wed, 25 Sep 2013 23:50:40 +0800 From: Jiang Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Christopher Covington CC: Jiang Liu , Steven Rostedt , Catalin Marinas , Will Deacon , Marc Zyngier , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/7] arm64: introduce basic aarch64 instruction decoding helpers References: <1380105868-31985-1-git-send-email-liuj97@gmail.com> <1380105868-31985-2-git-send-email-liuj97@gmail.com> <5242DE0F.1080601@codeaurora.org> In-Reply-To: <5242DE0F.1080601@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1552 Lines: 48 On 09/25/2013 08:58 PM, Christopher Covington wrote: > Hi Jiang, > > On 09/25/2013 06:44 AM, Jiang Liu wrote: > > [...] > >> diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c > > [...] > >> +static int aarch64_insn_cls[] = { >> + AARCH64_INSN_CLS_UNKNOWN, /* 0 0 X X */ >> + AARCH64_INSN_CLS_UNKNOWN, /* 0 0 X X */ >> + AARCH64_INSN_CLS_UNKNOWN, /* 0 0 X X */ >> + AARCH64_INSN_CLS_UNKNOWN, /* 0 0 X X */ >> + AARCH64_INSN_CLS_LDST, /* X 1 X 0 */ >> + AARCH64_INSN_CLS_DP_REG, /* X 1 0 1 */ >> + AARCH64_INSN_CLS_LDST, /* X 1 X 0 */ >> + AARCH64_INSN_CLS_DP_FPSIMD, /* 0 1 1 1 */ >> + AARCH64_INSN_CLS_DP_IMM, /* 1 0 0 X */ >> + AARCH64_INSN_CLS_DP_IMM, /* 1 0 0 X */ >> + AARCH64_INSN_CLS_BR_SYS, /* 1 0 1 X */ >> + AARCH64_INSN_CLS_BR_SYS, /* 1 0 1 X */ >> + AARCH64_INSN_CLS_LDST, /* X 1 X 0 */ >> + AARCH64_INSN_CLS_DP_REG, /* X 1 0 1 */ >> + AARCH64_INSN_CLS_LDST, /* X 1 X 0 */ >> + AARCH64_INSN_CLS_DP_FPSIMD, /* 1 1 1 1 */ >> +}; > > As I read this, I was initially puzzled as to why there are duplicate entries > in the list. Since the data structure doesn't really support don't-cares, > perhaps it would be clearer to use 1's and 0's instead of X's. Thanks for review, Chris! I will try to improve the comments in next version. > > [...] > > Thanks, > Christopher > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/