Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753430Ab3IYRNw (ORCPT ); Wed, 25 Sep 2013 13:13:52 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:41068 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956Ab3IYRNt (ORCPT ); Wed, 25 Sep 2013 13:13:49 -0400 Date: Wed, 25 Sep 2013 10:13:41 -0700 From: "Paul E. McKenney" To: Josh Triplett Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu, Michael Opdenacker Subject: Re: [PATCH tip/core/rcu 3/3] rcu: Fix occurrence of "the the" in checklist.txt Message-ID: <20130925171341.GX9093@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20130925011657.GA29958@linux.vnet.ibm.com> <1380071843-30362-1-git-send-email-paulmck@linux.vnet.ibm.com> <1380071843-30362-3-git-send-email-paulmck@linux.vnet.ibm.com> <20130925034739.GA2016@leaf> <20130925135527.GS9093@linux.vnet.ibm.com> <20130925153321.GA6269@leaf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130925153321.GA6269@leaf> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13092517-9332-0000-0000-0000018A75C4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3222 Lines: 69 On Wed, Sep 25, 2013 at 08:33:21AM -0700, Josh Triplett wrote: > On Wed, Sep 25, 2013 at 06:55:27AM -0700, Paul E. McKenney wrote: > > On Tue, Sep 24, 2013 at 08:47:39PM -0700, Josh Triplett wrote: > > > On Tue, Sep 24, 2013 at 06:17:23PM -0700, Paul E. McKenney wrote: > > > > From: Michael Opdenacker > > > > > > > > Signed-off-by: Michael Opdenacker > > > > Signed-off-by: Paul E. McKenney > > > > --- > > > > > > See comment below. > > > > > > > Documentation/RCU/checklist.txt | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/RCU/checklist.txt b/Documentation/RCU/checklist.txt > > > > index 7703ec7..ad6cba4 100644 > > > > --- a/Documentation/RCU/checklist.txt > > > > +++ b/Documentation/RCU/checklist.txt > > > > @@ -203,7 +203,7 @@ over a rather long period of time, but improvements are always welcome! > > > > the corresponding readers must disable preemption, possibly > > > > by calling rcu_read_lock_sched() and rcu_read_unlock_sched(). > > > > If the updater uses synchronize_srcu() or call_srcu(), > > > > - the the corresponding readers must use srcu_read_lock() and > > > > + the corresponding readers must use srcu_read_lock() and > > > > > > I think this may have actually been a typo for "then", as in "If the > > > updater uses ..., then the corresponding readers must use ...". > > > > Good point -- that would make the sentence construction parallel with > > the surrounding sentences. Updated patch below. > > > > Thanx, Paul > > > > rcu: Fix occurrence of "the the" in checklist.txt > > > > Signed-off-by: Michael Opdenacker > > Signed-off-by: Paul E. McKenney > > [ paulmck: Add "then" as suggested by Josh Triplett. ] > > Reviewed-by: Josh Triplett Got it, thank you again! Thanx, Paul > > diff --git a/Documentation/RCU/checklist.txt b/Documentation/RCU/checklist.txt > > index 7703ec7..9126619 100644 > > --- a/Documentation/RCU/checklist.txt > > +++ b/Documentation/RCU/checklist.txt > > @@ -202,8 +202,8 @@ over a rather long period of time, but improvements are always welcome! > > updater uses call_rcu_sched() or synchronize_sched(), then > > the corresponding readers must disable preemption, possibly > > by calling rcu_read_lock_sched() and rcu_read_unlock_sched(). > > - If the updater uses synchronize_srcu() or call_srcu(), > > - the the corresponding readers must use srcu_read_lock() and > > + If the updater uses synchronize_srcu() or call_srcu(), then > > + the corresponding readers must use srcu_read_lock() and > > srcu_read_unlock(), and with the same srcu_struct. The rules for > > the expedited primitives are the same as for their non-expedited > > counterparts. Mixing things up will result in confusion and > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/