Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754782Ab3IYSSX (ORCPT ); Wed, 25 Sep 2013 14:18:23 -0400 Received: from mail.skyhub.de ([78.46.96.112]:56534 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754663Ab3IYSSV (ORCPT ); Wed, 25 Sep 2013 14:18:21 -0400 Date: Wed, 25 Sep 2013 12:07:22 +0200 From: Borislav Petkov To: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, huawei.libin@huawei.com, wangyijing@huawei.com, fenghua.yu@intel.com, tglx@linutronix.de, guohanjun@huawei.com, paul.gortmaker@windriver.com Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/urgent] x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly Message-ID: <20130925100722.GB3433@nazgul.tnic> References: <1378378676-18276-1-git-send-email-huawei.libin@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2146 Lines: 47 On Thu, Sep 05, 2013 at 10:52:15AM -0700, tip-bot for Libin wrote: > Commit-ID: 52239484bf8aec031afa84ae08aa88224d819b93 > Gitweb: http://git.kernel.org/tip/52239484bf8aec031afa84ae08aa88224d819b93 > Author: Libin > AuthorDate: Thu, 5 Sep 2013 18:57:56 +0800 > Committer: Ingo Molnar > CommitDate: Thu, 5 Sep 2013 15:05:37 +0200 > > x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly > > When booting secondary CPUs, announce_cpu() is called to show which cpu has > been brought up. For example: > > [ 0.402751] smpboot: Booting Node 0, Processors #1 #2 #3 #4 #5 OK > [ 0.525667] smpboot: Booting Node 1, Processors #6 #7 #8 #9 #10 #11 OK > [ 0.755592] smpboot: Booting Node 0, Processors #12 #13 #14 #15 #16 #17 OK > [ 0.890495] smpboot: Booting Node 1, Processors #18 #19 #20 #21 #22 #23 > > But the last "OK" is lost, because 'nr_cpu_ids-1' represents the maximum > possible cpu id. It should use the maximum present cpu id in case not all > CPUs booted up. > > Signed-off-by: Libin > Cc: > Cc: > Cc: > Cc: > Link: http://lkml.kernel.org/r/1378378676-18276-1-git-send-email-huawei.libin@huawei.com > [ tweaked the changelog, removed unnecessary line break, tweaked the format to align the fields vertically. ] > Signed-off-by: Ingo Molnar Hmm, this one kinda funnied up output on smaller boxes: [ 0.089340] smpboot: Booting Node 0, Processors # 1 [ 0.105930] SMP alternatives: lockdep: fixing up alternatives [ 0.106073] # 2 [ 0.122237] SMP alternatives: lockdep: fixing up alternatives [ 0.122384] # 3 OK [ 0.136464] Brought up 4 CPUs [ 0.136539] smpboot: Total of 4 processors activated (23146.40 BogoMIPS) Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/