Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755346Ab3IYWtY (ORCPT ); Wed, 25 Sep 2013 18:49:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64499 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281Ab3IYWtX (ORCPT ); Wed, 25 Sep 2013 18:49:23 -0400 Date: Wed, 25 Sep 2013 18:49:13 -0400 From: Dave Jones To: Steven Rostedt Cc: Al Viro , Linux Kernel Subject: tracing: don't stuff stale pointers in filp->private_data Message-ID: <20130925224912.GA23473@redhat.com> Mail-Followup-To: Dave Jones , Steven Rostedt , Al Viro , Linux Kernel References: <20130920164732.GA31520@redhat.com> <20130921143255.GS13318@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 762 Lines: 26 Probably harmless, but still not a nice thing to do. Signed-off-by: Dave Jones diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 368a4d5..27aa16e 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -1124,10 +1124,10 @@ static int system_tr_open(struct inode *inode, struct file *filp) if (ret < 0) { trace_array_put(tr); kfree(dir); + } else { + filp->private_data = dir; } - filp->private_data = dir; - return ret; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/