Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754839Ab3IYXEa (ORCPT ); Wed, 25 Sep 2013 19:04:30 -0400 Received: from mail-vc0-f176.google.com ([209.85.220.176]:43922 "EHLO mail-vc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752428Ab3IYXE3 (ORCPT ); Wed, 25 Sep 2013 19:04:29 -0400 MIME-Version: 1.0 In-Reply-To: <1380125886-10341-7-git-send-email-fweisbec@gmail.com> References: <1380125886-10341-1-git-send-email-fweisbec@gmail.com> <1380125886-10341-7-git-send-email-fweisbec@gmail.com> Date: Wed, 25 Sep 2013 16:04:28 -0700 X-Google-Sender-Auth: DDR9GdTAA3F-pdYiuin74T10CHg Message-ID: Subject: Re: [PATCH 6/7] irq: Optimize softirq stack selection in irq exit From: Linus Torvalds To: Frederic Weisbecker Cc: LKML , Benjamin Herrenschmidt , Paul Mackerras , Ingo Molnar , Thomas Gleixner , Peter Zijlstra , "H. Peter Anvin" , James Hogan , "James E.J. Bottomley" , Helge Deller , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 889 Lines: 24 On Wed, Sep 25, 2013 at 9:18 AM, Frederic Weisbecker wrote: > +#ifdef __ARCH_IRQ_EXIT_ON_IRQ_STACK Please don't introduce anymore of these insane ad-hoc crazy architecture macros. Just make it a regular config option, which makes it much easier for architectures to just select it at config time. So make it something like CONFIG_IRQ_EXIT_ON_IRQ_STACK, and then x86-64 (and now Power) can just do select IRQ_EXIT_ON_IRQ_STACK in their arch/*/Kconfig files. Basically, we really should strive to get rid of all those insane [__]ARCH_xyzzy flags. We have too many of them, and they are insane. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/