Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754063Ab3IZDse (ORCPT ); Wed, 25 Sep 2013 23:48:34 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:38846 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172Ab3IZDsd (ORCPT ); Wed, 25 Sep 2013 23:48:33 -0400 Date: Thu, 26 Sep 2013 04:48:28 +0100 From: Al Viro To: Alexander Holler Cc: Bjorn Helgaas , Peter Senna Tschudin , Dan Carpenter , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: checkpatch guide for newbies Message-ID: <20130926034828.GJ13318@ZenIV.linux.org.uk> References: <5241CB44.8080004@ahsoftware.de> <52420DF1.7060108@ahsoftware.de> <20130926021130.GD13318@ZenIV.linux.org.uk> <5243A165.2060204@ahsoftware.de> <5243A29C.6080009@ahsoftware.de> <20130926030448.GG13318@ZenIV.linux.org.uk> <5243A993.9070108@ahsoftware.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5243A993.9070108@ahsoftware.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1089 Lines: 23 On Thu, Sep 26, 2013 at 05:27:15AM +0200, Alexander Holler wrote: > Oh, personally I don't have any limit there. ;) I like descriptive > function and variable names whenever they make sense. And often they > make comments uneccessary and therefor prevent errors because those > descriptive names are visible whenever the function or variable is > used, and comments usually appear only once and get forgotten when > scrolled out of the screen. > > But just take a function like > > void get_xtime_and_monotonic_and_sleep_offset(struct timespec *xtim, > struct timespec *wtom, struct > timespec *sleep); Charming... Now, try to tell one such name from another, when the only difference is buried in the middle of long phrase. And yes, I've seen mistakes clearly of that origin. Made them myself, actually. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/