Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755984Ab3IZICL (ORCPT ); Thu, 26 Sep 2013 04:02:11 -0400 Received: from gate.crashing.org ([63.228.1.57]:60022 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750891Ab3IZICG (ORCPT ); Thu, 26 Sep 2013 04:02:06 -0400 Message-ID: <1380182487.28561.22.camel@pasglop> Subject: Re: [PATCH 2/3] hwrng: Add a driver for the hwrng found in power7+ systems From: Benjamin Herrenschmidt To: Michael Ellerman Cc: linux-kernel@vger.kernel.org, Paul Mackerras , gleb@redhat.com, pbonzini@redhat.com, agraf@suse.de, mpm@selenic.com, herbert@gondor.hengli.com.au, linuxppc-dev@ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, tytso@mit.edu Date: Thu, 26 Sep 2013 18:01:27 +1000 In-Reply-To: <1380177066-3835-2-git-send-email-michael@ellerman.id.au> References: <1380177066-3835-1-git-send-email-michael@ellerman.id.au> <1380177066-3835-2-git-send-email-michael@ellerman.id.au> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 515 Lines: 18 On Thu, 2013-09-26 at 16:31 +1000, Michael Ellerman wrote: > + pr_info("registered powernv hwrng.\n"); First letter of a line should get a capital :-) Also since it's per-device, at least indicate the OF path or the chip number or something ... Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/