Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755898Ab3IZIZG (ORCPT ); Thu, 26 Sep 2013 04:25:06 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:63287 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030Ab3IZIZD (ORCPT ); Thu, 26 Sep 2013 04:25:03 -0400 Message-ID: <5243EF5C.6060908@linaro.org> Date: Thu, 26 Sep 2013 10:25:00 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Viresh Kumar CC: "Rafael J. Wysocki" , Lists linaro-kernel , Patch Tracking , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [PATCH 08/21] cpuidle: use cpuidle_disabled() instead of "off" References: <19979ce88726285c72dd6fe3d7b370d53669443c.1379779777.git.viresh.kumar@linaro.org> <52435B05.9030201@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1231 Lines: 32 On 09/26/2013 07:06 AM, Viresh Kumar wrote: > On 26 September 2013 03:22, Daniel Lezcano wrote: >> On 09/22/2013 03:21 AM, Viresh Kumar wrote: >>> We have a routine for getting value of "off", better call that instead of using >>> "off" directly. >> >> We are in the fast path, I am not sure invoking a function here is >> better than using directly the static variable. > > I only did it for consistency as we have this routine specifically for reading > value of "off" and so we better don't use off directly.. > > Probably we can make it static inline and move it into > drivers/cpuidle/cpuidle.h? If you move it to cpuidle.h, you will have to move the 'off' variable in the header hence increasing the scope of it. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/