Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755605Ab3IZI4n (ORCPT ); Thu, 26 Sep 2013 04:56:43 -0400 Received: from mail-vc0-f172.google.com ([209.85.220.172]:55275 "EHLO mail-vc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999Ab3IZI4l (ORCPT ); Thu, 26 Sep 2013 04:56:41 -0400 MIME-Version: 1.0 In-Reply-To: <1379585845.1822.7.camel@x220.thuisdomein> References: <1379013442.11313.5.camel@x220.thuisdomein> <1379014276.11313.9.camel@x220.thuisdomein> <5B8DA87D05A7694D9FA63FD143655C1B1AEC3CE1@HASMSX106.ger.corp.intel.com> <1379585845.1822.7.camel@x220.thuisdomein> Date: Thu, 26 Sep 2013 11:56:40 +0300 Message-ID: Subject: Re: [PATCH v2] mei: me: downgrade two errors to debug level From: Tomas Winkler To: Paul Bolle Cc: Adam Jackson , Joe Perches , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1643 Lines: 49 On Thu, Sep 19, 2013 at 1:17 PM, Paul Bolle wrote: > The mei_me driver prints "suspend" at error level at each suspend. It > also prints "stop" at error level at driver unload. Downgrade these > uninteresting messages to debug level. > > Signed-off-by: Paul Bolle > --- > 0) v1 was called "mei: me: downgrade "suspend" message to debug level". > v2 also downgrades the "stop" message. > > 1) Added Adam and Joe to Cc:. They were involved in discussing a patch > by Adam, which was similar to my v1, about a week ago. > > 2) Still lightly tested only, but now on top of v3.11.1. > > drivers/misc/mei/pci-me.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c > index 1b3844e..897ee6b 100644 > --- a/drivers/misc/mei/pci-me.c > +++ b/drivers/misc/mei/pci-me.c > @@ -231,7 +231,7 @@ static void mei_me_remove(struct pci_dev *pdev) > hw = to_me_hw(dev); > > > - dev_err(&pdev->dev, "stop\n"); > + dev_dbg(&pdev->dev, "stop\n"); > mei_stop(dev); > > /* disable interrupts */ > @@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device) > if (!dev) > return -ENODEV; > > - dev_err(&pdev->dev, "suspend\n"); > + dev_dbg(&pdev->dev, "suspend\n"); > > mei_stop(dev); > > -- > 1.8.1.4 Ack -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/