Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756384Ab3IZJbT (ORCPT ); Thu, 26 Sep 2013 05:31:19 -0400 Received: from eu1sys200aog106.obsmtp.com ([207.126.144.121]:60872 "EHLO eu1sys200aog106.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756357Ab3IZJbQ convert rfc822-to-8bit (ORCPT ); Thu, 26 Sep 2013 05:31:16 -0400 From: Maxime COQUELIN To: Wolfram Sang Cc: Stephen Warren , Srinivas KANDAGATLA , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Rob Landley , Russell King , Grant Likely , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-i2c@vger.kernel.org" , Stephen GALLIMORE , Stuart MENEFY , Lee Jones , Gabriel FERNANDEZ , Olivier CLERGEAUD Date: Thu, 26 Sep 2013 11:30:23 +0200 Subject: Re: [PATCH 1/4] i2c: busses: i2c-st: Add ST I2C controller Thread-Topic: [PATCH 1/4] i2c: busses: i2c-st: Add ST I2C controller Thread-Index: Ac66mwd3ub2Ry6LIS2ach1A27oV7OA== Message-ID: <5243FEAF.4090506@st.com> References: <1379498483-4236-1-git-send-email-maxime.coquelin@st.com> <1379498483-4236-2-git-send-email-maxime.coquelin@st.com> <5240AD6E.4090905@wwwdotorg.org> <5241B1FA.6020500@st.com> <20130924155925.GA2995@katana> In-Reply-To: <20130924155925.GA2995@katana> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 acceptlanguage: en-US Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1032 Lines: 28 On 09/24/2013 05:59 PM, Wolfram Sang wrote: >> "glitch" is is used to tune the I2C timing requirements, and has a >> nanosecond granularity. >> These values are added to default timing values. >> I'm not 100% sure, but it looks like the "samsung,i2c-sda-delay" in the >> i2c-s3c2410 driver. > For that, we have the generic "i2c-sda-hold-time-ns" property. The s3c > driver hasn't been converted to use it, sadly. > Ok, thank you for pointing this out. After some checks, this property doesn't match with what is done in this driver. In the v2 series I am sending, I removed the I2C timing tuning as it works on all the boards I have tested with. I will only keep the anti-glitch filtering, using private properties as I didn't find any generic ones that could fit. Regards, Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/