Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756773Ab3IZLBh (ORCPT ); Thu, 26 Sep 2013 07:01:37 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:1661 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756353Ab3IZLBe (ORCPT ); Thu, 26 Sep 2013 07:01:34 -0400 Message-ID: <52441407.9010603@nod.at> Date: Thu, 26 Sep 2013 13:01:27 +0200 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Ramkumar Ramachandra CC: linux-arch@vger.kernel.org, Michal Marek , geert@linux-m68k.org, ralf@linux-mips.org, lethal@linux-sh.org, Jeff Dike , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kbuild@vger.kernel.org, LKML , linux-m68k@vger.kernel.org, linux-mips@linux-mips.org, linux-sh@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net Subject: Re: [PATCH 2/8] um: Do not use SUBARCH References: <1377073172-3662-1-git-send-email-richard@nod.at> <1377073172-3662-3-git-send-email-richard@nod.at> <52441025.9030308@nod.at> In-Reply-To: X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1628 Lines: 38 Am 26.09.2013 12:53, schrieb Ramkumar Ramachandra: > Richard Weinberger wrote: >> So, what exactly is broken in upstream? >> make defconfig works as it always did. > > Auto-detection of SUBARCH, which can be done with a simple call to > uname -m (the 90% case). The second patch I submitted prevented > spawning xterms unnecessarily, which we discussed was a good move. Covering only 90% of all cases is not enough. We must not break existing setups. That's also why my "Get rid of SUBARCH" series is not upstream. Your second patch changed CONFIG_CON_CHAN to pts, which is ok but not a major issue. The xterms are also not spawning unnecessarily they spawn upon a tty device is opened. With your patch UML create another pts. Thus, the spawning is hidden... I did not push it upstream because it depended on your first one and as I said, it's not critical. This does not mean that I moved it to /dev/null. Again, the plan is to get rid of SUBARCH at all. >> make defconfig ARCH=um SUBARCH=x86 (or SUBARCH=i386) will create a defconfig for 32bit. >> make defconfig ARCH=um SUBARCH=x86_64 one for 64bit. > > Yes, that's how I prepared the patch in the first place. So, nothing is broken. If you want "make defconfig ARCH=um" creating a defconfig for the correct arch you need more than your first patch. Again, "Get rid of SUBARCH" series has the same goal. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/