Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756985Ab3IZMbS (ORCPT ); Thu, 26 Sep 2013 08:31:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52043 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756460Ab3IZMbR (ORCPT ); Thu, 26 Sep 2013 08:31:17 -0400 Date: Thu, 26 Sep 2013 14:30:56 +0200 From: Jiri Olsa To: Vince Weaver Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Corey Ashford , Frederic Weisbecker , Ingo Molnar , Paul Mackerras , Peter Zijlstra Subject: Re: [PATCH 06/21] perf: Add event toggle ioctl interface Message-ID: <20130926123056.GE1067@krava.brq.redhat.com> References: <1380113447-17144-1-git-send-email-jolsa@redhat.com> <1380113447-17144-7-git-send-email-jolsa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 24 On Wed, Sep 25, 2013 at 03:46:58PM -0400, Vince Weaver wrote: > On Wed, 25 Sep 2013, Jiri Olsa wrote: > > > --- a/include/uapi/linux/perf_event.h > > +++ b/include/uapi/linux/perf_event.h > > @@ -325,6 +325,7 @@ struct perf_event_attr { > > #define PERF_EVENT_IOC_SET_OUTPUT _IO ('$', 5) > > #define PERF_EVENT_IOC_SET_FILTER _IOW('$', 6, char *) > > #define PERF_EVENT_IOC_ID _IOR('$', 7, u64 *) > > +#define PERF_EVENT_IOC_SET_TOGGLE _IOW('$', 8, u64 *) > > I'm pretty sure this should be __u64 or else it won't compile > in userspace. hum, we define u64 in perf 'util/types.h', that's why I missed that.. I'll send a fix for the PERF_EVENT_IOC_ID as well thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/