Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757181Ab3IZNCX (ORCPT ); Thu, 26 Sep 2013 09:02:23 -0400 Received: from smtpauth03h.mfg.siteprotect.com ([64.26.60.134]:59871 "EHLO smtpauth03.mfg.siteprotect.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756831Ab3IZNCW (ORCPT ); Thu, 26 Sep 2013 09:02:22 -0400 Date: Thu, 26 Sep 2013 09:03:57 -0400 (EDT) From: Vince Weaver X-X-Sender: vince@pianoman.cluster.toy To: Jiri Olsa cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Corey Ashford , Frederic Weisbecker , Ingo Molnar , Paul Mackerras , Peter Zijlstra Subject: Re: [PATCH 06/21] perf: Add event toggle ioctl interface In-Reply-To: <20130926123056.GE1067@krava.brq.redhat.com> Message-ID: References: <1380113447-17144-1-git-send-email-jolsa@redhat.com> <1380113447-17144-7-git-send-email-jolsa@redhat.com> <20130926123056.GE1067@krava.brq.redhat.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-CTCH-Spam: Unknown X-CTCH-RefID: str=0001.0A020205.5244305D.012D,ss=1,re=0.000,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1131 Lines: 29 On Thu, 26 Sep 2013, Jiri Olsa wrote: > On Wed, Sep 25, 2013 at 03:46:58PM -0400, Vince Weaver wrote: > > On Wed, 25 Sep 2013, Jiri Olsa wrote: > > > > > --- a/include/uapi/linux/perf_event.h > > > +++ b/include/uapi/linux/perf_event.h > > > @@ -325,6 +325,7 @@ struct perf_event_attr { > > > #define PERF_EVENT_IOC_SET_OUTPUT _IO ('$', 5) > > > #define PERF_EVENT_IOC_SET_FILTER _IOW('$', 6, char *) > > > #define PERF_EVENT_IOC_ID _IOR('$', 7, u64 *) > > > +#define PERF_EVENT_IOC_SET_TOGGLE _IOW('$', 8, u64 *) > > > > I'm pretty sure this should be __u64 or else it won't compile > > in userspace. > > hum, we define u64 in perf 'util/types.h', that's why I missed that.. > I'll send a fix for the PERF_EVENT_IOC_ID as well I sent in a fix for that recently and I think it's upstream already. That's why I noticed the issue when reviewing the perf_event.h changes. Vince -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/