Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757353Ab3IZNOA (ORCPT ); Thu, 26 Sep 2013 09:14:00 -0400 Received: from mail-ie0-f170.google.com ([209.85.223.170]:64165 "EHLO mail-ie0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756759Ab3IZNN5 (ORCPT ); Thu, 26 Sep 2013 09:13:57 -0400 MIME-Version: 1.0 In-Reply-To: References: <1377073172-3662-1-git-send-email-richard@nod.at> <1377073172-3662-3-git-send-email-richard@nod.at> <52441025.9030308@nod.at> <52441407.9010603@nod.at> <52442108.1020304@nod.at> From: Ramkumar Ramachandra Date: Thu, 26 Sep 2013 18:43:16 +0530 Message-ID: Subject: Re: [PATCH 2/8] um: Do not use SUBARCH To: Richard Weinberger Cc: linux-arch@vger.kernel.org, Michal Marek , geert@linux-m68k.org, ralf@linux-mips.org, lethal@linux-sh.org, Jeff Dike , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kbuild@vger.kernel.org, LKML , linux-m68k@vger.kernel.org, linux-mips@linux-mips.org, linux-sh@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1107 Lines: 26 Ramkumar Ramachandra wrote: > Richard Weinberger wrote: >> I told you already that "make defconfig ARCH=um SUBARCH=x86" will spuriously >> create a x86_64 config on x86_64. >> This breaks existing setups. > > I'll fix this and resubmit soon. Wait a minute. You're now arguing about whether the generic "x86" means i386 or x86_64. Its meaning is already defined in arch/x86/Kconfig and arch/x86/um/Kconfig: see the config 64BIT. Unless i386 is explicitly specified, the default is to build a 64-bit kernel. That is already defined for a normal Linux kernel, and user-mode Linux should not break that convention. So, in the example you pulled out of your hat: $ make defconfig ARCH=um SUBARCH=x86 the user should expect a 64-bit build, and not an i386 build as you say. Both my patches are correct, and the "regression" that you pointed out is a red herring. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/