Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750888Ab3IZNfA (ORCPT ); Thu, 26 Sep 2013 09:35:00 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:36167 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738Ab3IZNe6 (ORCPT ); Thu, 26 Sep 2013 09:34:58 -0400 Message-ID: <52443800.5080200@gmail.com> Date: Thu, 26 Sep 2013 07:34:56 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Sonny Rao , Arnaldo Carvalho de Melo CC: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Jiri Olsa , Namhyung Kim , Stephane Eranian Subject: Re: [PATCH] perf: fix infinite loop with corrupted header References: <1380172836-13936-1-git-send-email-sonnyrao@chromium.org> In-Reply-To: <1380172836-13936-1-git-send-email-sonnyrao@chromium.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 19 On 9/25/13 11:20 PM, Sonny Rao wrote: > We recently ran into a corrupt perf data file which mostly looked okay > but the section size for data was set to 0. This caused perf report to > get into an infinite loop in __perf_session_process_events(). Let's > just avoid this by bailing early and reporting it if there's an > invalid header. Been suggested before: https://lkml.org/lkml/2013/5/9/405 Other changes went in around that time as well. Are you still seeing the loop on latest source? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/