Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353Ab3IZPXr (ORCPT ); Thu, 26 Sep 2013 11:23:47 -0400 Received: from mx11.netapp.com ([216.240.18.76]:26961 "EHLO mx11.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800Ab3IZPXq convert rfc822-to-8bit (ORCPT ); Thu, 26 Sep 2013 11:23:46 -0400 X-IronPort-AV: E=Sophos;i="4.90,986,1371106800"; d="scan'208";a="53561587" From: "Myklebust, Trond" To: "J. Bruce Fields" , David Howells CC: "olof@lixom.net" , "linux-nfs@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [RFC][PATCH 0/4] SunRPC/NFS: Use no_printk() in Thread-Topic: [RFC][PATCH 0/4] SunRPC/NFS: Use no_printk() in Thread-Index: AQHOuswXLcLQi0hNs0m4vvJDyI+VYpnYIvAg Date: Thu, 26 Sep 2013 15:23:45 +0000 Message-ID: <4FA345DA4F4AE44899BD2B03EEEC2FA9467EB040@SACEXCMBX04-PRD.hq.netapp.com> References: <20130926144502.29424.21633.stgit@warthog.procyon.org.uk> <20130926152125.GD704@fieldses.org> In-Reply-To: <20130926152125.GD704@fieldses.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.106.53.51] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1183 Lines: 31 > -----Original Message----- > From: J. Bruce Fields [mailto:bfields@fieldses.org] > Sent: Thursday, September 26, 2013 10:21 AM > To: David Howells > Cc: Myklebust, Trond; olof@lixom.net; linux-nfs@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: Re: [RFC][PATCH 0/4] SunRPC/NFS: Use no_printk() in > > On Thu, Sep 26, 2013 at 03:45:02PM +0100, David Howells wrote: > > > > > > Here's a series of patches to make SunRPC/NFS use no_printk() to > > implement its null dfprintk() macro (ie. when RPC_DEBUG is disabled). > > This prevents 'unused variable' errors from occurring when a variable > > is set only for use in debugging statements and renders RPC/NFS_IFDEBUG > unnecessary. > > Does this patch series fix any actual warnings? Or does it just change the way > that we prevent the warnings? > Right. If this is just code churn, then let's drop it. Otherwise, please explain why it is a good idea. Cheers, Trond -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/