Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753419Ab3IZQDe (ORCPT ); Thu, 26 Sep 2013 12:03:34 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:54013 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751362Ab3IZQDa (ORCPT ); Thu, 26 Sep 2013 12:03:30 -0400 Message-ID: <52445AB5.8030306@gmail.com> Date: Fri, 27 Sep 2013 00:03:01 +0800 From: Zhang Yanfei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120607 Thunderbird/10.0.5 MIME-Version: 1.0 To: Tejun Heo CC: "Rafael J . Wysocki" , lenb@kernel.org, Thomas Gleixner , mingo@elte.hu, "H. Peter Anvin" , Andrew Morton , Toshi Kani , Wanpeng Li , Thomas Renninger , Yinghai Lu , Jiang Liu , Wen Congyang , Lai Jiangshan , isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, Mel Gorman , Minchan Kim , mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, Rik van Riel , jweiner@redhat.com, prarit@redhat.com, "x86@kernel.org" , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux MM , linux-acpi@vger.kernel.org, imtangchen@gmail.com, Zhang Yanfei Subject: Re: [PATCH v5 4/6] x86/mem-hotplug: Support initialize page tables in bottom-up References: <5241D897.1090905@gmail.com> <5241DA5B.8000909@gmail.com> <20130926144851.GF3482@htj.dyndns.org> <52445606.7030108@gmail.com> <20130926154813.GA32391@mtj.dyndns.org> In-Reply-To: <20130926154813.GA32391@mtj.dyndns.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1433 Lines: 32 On 09/26/2013 11:48 PM, Tejun Heo wrote: > On Thu, Sep 26, 2013 at 11:43:02PM +0800, Zhang Yanfei wrote: >>> As Yinghai pointed out in another thread, do we need to worry about >>> falling back to top-down? >> >> I've explained to him. Nop, we don't need to worry about that. Because even >> the min_pfn_mapped becomes ISA_END_ADDRESS in the second call below, we won't >> allocate memory below the kernel because we have limited the allocation above >> the kernel. > > Maybe I misunderstood but wasn't he worrying about there not being > enough space above kernel? In that case, it'd automatically fall back > to top-down allocation anyway, right? Ah, I see. You are saying another issue. He is worrying that if we use kexec to load the kernel high, say we have 16GB, we put the kernel in 15.99GB (just an example), so we only have less than 100MB above the kernel. But as I've explained to him, in almost all the cases, if we want our memory hotplug work, we don't do that. And yeah, assume we have this problem, it'd fall back to top down and that return backs to patch 2, we will trigger the WARN_ONCE, and the admin will know what has happened. Thanks. -- Thanks. Zhang Yanfei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/