Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753443Ab3IZQhk (ORCPT ); Thu, 26 Sep 2013 12:37:40 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:51666 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124Ab3IZQhh convert rfc822-to-8bit (ORCPT ); Thu, 26 Sep 2013 12:37:37 -0400 Subject: Re: [PATCHv4 2/3] ARM: msm: Add support for APQ8074 Dragonboard Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=US-ASCII From: Kumar Gala In-Reply-To: <5243652F.7090408@codeaurora.org> Date: Thu, 26 Sep 2013 11:37:33 -0500 Cc: David Brown , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Russell King , Daniel Walker , Bryan Huntsman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Transfer-Encoding: 7BIT Message-Id: References: <1379992406-3541-1-git-send-email-rvaswani@codeaurora.org> <1379992406-3541-2-git-send-email-rvaswani@codeaurora.org> <4E7868D6-56CB-4AF8-8EBF-069966899C23@codeaurora.org> <5243652F.7090408@codeaurora.org> To: Rohit Vaswani X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4941 Lines: 143 On Sep 25, 2013, at 5:35 PM, Rohit Vaswani wrote: > On 9/25/2013 12:49 PM, Kumar Gala wrote: >> On Sep 23, 2013, at 10:13 PM, Rohit Vaswani wrote: >> >>> This patch adds basic board support for APQ8074 Dragonboard >>> which belongs to the Snapdragon 800 family. >>> For now, just support a basic machine with device tree. >>> >>> Signed-off-by: Rohit Vaswani >>> --- >>> arch/arm/Kconfig.debug | 9 +++++++ >>> arch/arm/boot/dts/Makefile | 3 ++- >>> arch/arm/boot/dts/qcom-apq8074-dragonboard.dts | 6 +++++ >>> arch/arm/boot/dts/qcom-msm8974.dtsi | 35 ++++++++++++++++++++++++++ >>> arch/arm/include/debug/msm.S | 5 ++++ >>> arch/arm/mach-msm/Kconfig | 13 ++++++++++ >>> arch/arm/mach-msm/board-dt.c | 9 +++++++ >>> 7 files changed, 79 insertions(+), 1 deletion(-) >>> create mode 100644 arch/arm/boot/dts/qcom-apq8074-dragonboard.dts >>> create mode 100644 arch/arm/boot/dts/qcom-msm8974.dtsi >>> >>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug >>> index e18a6fc..959b2c7 100644 >>> --- a/arch/arm/Kconfig.debug >>> +++ b/arch/arm/Kconfig.debug >>> @@ -357,6 +357,15 @@ choice >>> Say Y here if you want the debug print routines to direct >>> their output to the serial port on MSM 8960 devices. >>> >>> + config DEBUG_MSM8974_UART >>> + bool "Kernel low-level debugging messages via MSM 8974 UART" >>> + depends on ARCH_MSM8974 >>> + select MSM_HAS_DEBUG_UART_HS >>> + select DEBUG_MSM_UART >>> + help >>> + Say Y here if you want the debug print routines to direct >>> + their output to the serial port on MSM 8974 devices. >>> + >> A little surprised you didn't pull this and the ARCH_MSM8974 into its own patch outside of this patch being board support. > > Well, its good to have this as part of initial board setup for earlyprintk. I agree, just figured it would have been a standalone patch and a precursor to this patch. >>> config DEBUG_MVEBU_UART >>> bool "Kernel low-level debugging messages via MVEBU UART (old bootloaders)" >>> depends on ARCH_MVEBU >>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >>> index 000cf76..e71a3ec 100644 >>> --- a/arch/arm/boot/dts/Makefile >>> +++ b/arch/arm/boot/dts/Makefile >>> @@ -102,7 +102,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ >>> kirkwood-openblocks_a6.dtb >>> dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb >>> dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ >>> - msm8960-cdp.dtb >>> + msm8960-cdp.dtb \ >>> + qcom-apq8074-dragonboard.dtb >>> dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \ >>> armada-370-mirabox.dtb \ >>> armada-370-netgear-rn102.dtb \ >>> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts >>> new file mode 100644 >>> index 0000000..bb6f3c4 >>> --- /dev/null >>> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts >>> @@ -0,0 +1,6 @@ >>> +/include/ "qcom-msm8974.dtsi" >>> + >>> +/ { >>> + model = "Qualcomm APQ8074 Dragonboard"; >>> + compatible = "qcom,apq8074-dragonboard", "qcom,apq8074"; >>> +}; >>> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi >>> new file mode 100644 >>> index 0000000..f04b643 >>> --- /dev/null >>> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi >>> @@ -0,0 +1,35 @@ >>> +/dts-v1/; >>> + >>> +/include/ "skeleton.dtsi" >>> + >>> +/ { >>> + model = "Qualcomm MSM8974"; >>> + compatible = "qcom,msm8974"; >>> + interrupt-parent = <&intc>; >>> + >>> + soc: soc { }; >> We should have a unit address here: >> >> soc: soc@FOOBAR { >> >> also, split out the curly braces so any future patches do have to muck with that. >> >> }; >> > > Im not sure I understand the reasoning behind the unit address for soc ? Its fairly standard practice and there is a fair amount of discussion about the lack of a unit address for memory nodes. >>> +}; >>> + >>> +&soc { >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + ranges; >>> + compatible = "simple-bus"; >>> + >>> + intc: interrupt-controller@f9000000 { >>> + compatible = "qcom,msm-qgic2"; >>> + interrupt-controller; >>> + #interrupt-cells = <3>; >>> + reg = <0xf9000000 0x1000>, >>> + <0xf9002000 0x1000>; >>> + }; >>> + >>> + timer { >>> + compatible = "arm,armv7-timer"; >>> + interrupts = <1 2 0xf08>, >>> + <1 3 0xf08>, >>> + <1 4 0xf08>, >>> + <1 1 0xf08>; >>> + clock-frequency = <19200000>; >>> + }; >>> +}; - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/