Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753588Ab3IZQ5D (ORCPT ); Thu, 26 Sep 2013 12:57:03 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:58195 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752799Ab3IZQ5A (ORCPT ); Thu, 26 Sep 2013 12:57:00 -0400 Message-ID: <52446748.7090001@gmail.com> Date: Fri, 27 Sep 2013 00:56:40 +0800 From: Zhang Yanfei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120607 Thunderbird/10.0.5 MIME-Version: 1.0 To: Tejun Heo CC: "Rafael J . Wysocki" , lenb@kernel.org, Thomas Gleixner , mingo@elte.hu, "H. Peter Anvin" , Andrew Morton , Toshi Kani , Wanpeng Li , Thomas Renninger , Yinghai Lu , Jiang Liu , Wen Congyang , Lai Jiangshan , isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, Mel Gorman , Minchan Kim , mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, Rik van Riel , jweiner@redhat.com, prarit@redhat.com, "x86@kernel.org" , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux MM , linux-acpi@vger.kernel.org, imtangchen@gmail.com, Zhang Yanfei Subject: Re: [PATCH v5 3/6] x86/mm: Factor out of top-down direct mapping setup References: <5241D897.1090905@gmail.com> <5241D9F2.80908@gmail.com> <20130926144642.GE3482@htj.dyndns.org> <5244553A.2050700@gmail.com> In-Reply-To: <5244553A.2050700@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1504 Lines: 53 Hello tejun, On 09/26/2013 11:39 PM, Zhang Yanfei wrote: > On 09/26/2013 10:46 PM, Tejun Heo wrote: >> On Wed, Sep 25, 2013 at 02:29:06AM +0800, Zhang Yanfei wrote: >>> +/** >>> + * memory_map_top_down - Map [map_start, map_end) top down >>> + * @map_start: start address of the target memory range >>> + * @map_end: end address of the target memory range >>> + * >>> + * This function will setup direct mapping for memory range >>> + * [map_start, map_end) in top-down. >> >> Can you please put a bit more effort into the function description? > > Sorry.... I will try to make a more detailed description. Trying below: /** * memory_map_top_down - Map [map_start, map_end) top down * @map_start: start address of the target memory range * @map_end: end address of the target memory range * * This function will setup direct mapping for memory range * [map_start, map_end) in top-down. That said, the page tables * will be allocated at the end of the memory, and we map the * memory top-down. */ static void __init memory_map_top_down(unsigned long map_start, unsigned long map_end) { Thanks. > >> >> Other than that, >> >> Acked-by: Tejun Heo > > Thanks. > -- Thanks. Zhang Yanfei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/