Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753565Ab3IZRd7 (ORCPT ); Thu, 26 Sep 2013 13:33:59 -0400 Received: from mail-qa0-f51.google.com ([209.85.216.51]:39927 "EHLO mail-qa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792Ab3IZRd5 (ORCPT ); Thu, 26 Sep 2013 13:33:57 -0400 MIME-Version: 1.0 In-Reply-To: <52443800.5080200@gmail.com> References: <1380172836-13936-1-git-send-email-sonnyrao@chromium.org> <52443800.5080200@gmail.com> From: Sonny Rao Date: Thu, 26 Sep 2013 10:33:35 -0700 X-Google-Sender-Auth: vbWXIYYh4qaMTVESczPMZRfOswg Message-ID: Subject: Re: [PATCH] perf: fix infinite loop with corrupted header To: David Ahern Cc: Arnaldo Carvalho de Melo , "linux-kernel@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Jiri Olsa , Namhyung Kim , Stephane Eranian Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 945 Lines: 27 On Thu, Sep 26, 2013 at 6:34 AM, David Ahern wrote: > On 9/25/13 11:20 PM, Sonny Rao wrote: >> >> We recently ran into a corrupt perf data file which mostly looked okay >> but the section size for data was set to 0. This caused perf report to >> get into an infinite loop in __perf_session_process_events(). Let's >> just avoid this by bailing early and reporting it if there's an >> invalid header. > > > Been suggested before: > https://lkml.org/lkml/2013/5/9/405 > > Other changes went in around that time as well. Are you still seeing the > loop on latest source? I'm still seeing it on 3.12-rc1. I haven't tested anything newer or in the perf git tree. Thanks > > David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/