Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754537Ab3IZV4v (ORCPT ); Thu, 26 Sep 2013 17:56:51 -0400 Received: from mail-oa0-f54.google.com ([209.85.219.54]:39687 "EHLO mail-oa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754485Ab3IZV4s convert rfc822-to-8bit (ORCPT ); Thu, 26 Sep 2013 17:56:48 -0400 MIME-Version: 1.0 In-Reply-To: <8738os2tqt.fsf@octavius.laptop.org> References: <1379611214-1089-1-git-send-email-grundler@chromium.org> <87fvss2uh9.fsf@octavius.laptop.org> <8738os2tqt.fsf@octavius.laptop.org> Date: Thu, 26 Sep 2013 14:56:47 -0700 X-Google-Sender-Auth: f5IP14y6Y1ZAftiDYM-b33r7C_Y Message-ID: Subject: Re: [PATCH] mmc: core: remove issue_fn indirect function call From: Grant Grundler To: Chris Ball Cc: Ulf Hansson , Grant Grundler , Seungwon Jeon , linux-mmc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1695 Lines: 47 On Wed, Sep 25, 2013 at 7:37 PM, Chris Ball wrote: > Hi, > > On Wed, Sep 25 2013, Chris Ball wrote: >> Hi, >> >> On Fri, Sep 20 2013, Ulf Hansson wrote: >>> On 19 September 2013 19:20, Grant Grundler wrote: >>>> struct mmc_queue defines issue_fn as an indirect function call. >>>> issue_fn field only gets set to mmc_blk_issue_rq and only gets >>>> invoked immediately after calling blk_fetch_request(). >>>> Don't bother with indirect function call - it's pointless and just >>>> obfuscates the code. >>>> >>>> Signed-off-by: Grant Grundler >>> >>> Acked-by: Ulf Hansson >> >> Thanks, pushed to mmc-next for 3.13. > > Have dropped this, it's breaking my build: > > /home/cjb/git/mmc/drivers/mmc/card/block.c:1955:12: warning: ‘mmc_blk_issue_rq’ defined but not used [-Wunused-function] The function is declared static. :( Let me respin to remove the static and add a function prototype to a header file. I just got lucky when I built this in an earlier tree. sorry about that... grant > /home/cjb/git/mmc/drivers/mmc/card/queue.c: In function ‘mmc_queue_thread’: > /home/cjb/git/mmc/drivers/mmc/card/queue.c:70:4: error: implicit declaration of function ‘mmc_blk_issue_rq’ [-Werror=implicit-function-declaration] > > Grant, please could you take a look and resubmit? > > - Chris. > -- > Chris Ball -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/