Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754764Ab3IZWUz (ORCPT ); Thu, 26 Sep 2013 18:20:55 -0400 Received: from co1ehsobe005.messaging.microsoft.com ([216.32.180.188]:29888 "EHLO co1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754049Ab3IZWUv (ORCPT ); Thu, 26 Sep 2013 18:20:51 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: 2 X-BigFish: VS2(zz98dI9371I936eI542I1432Id725ozz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzz1de098h1de097h8275bhz2dh2a8h839h93fhd24hf0ah1288h12a5h12a9h12bdh137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1e23h1fe8h1ff5h1155h) Message-ID: <1380234044.24959.339.camel@snotra.buserror.net> Subject: Re: [PATCH 5/7] iommu: supress loff_t compilation error on powerpc From: Scott Wood To: Bhushan Bharat-R65777 CC: Alex Williamson , "joro@8bytes.org" , "benh@kernel.crashing.org" , "galak@kernel.crashing.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-pci@vger.kernel.org" , "agraf@suse.de" , Wood Scott-B07421 , "iommu@lists.linux-foundation.org" Date: Thu, 26 Sep 2013 17:20:44 -0500 In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D07183CA4@039-SN2MPN1-011.039d.mgd.msft.net> References: <1379575763-2091-1-git-send-email-Bharat.Bhushan@freescale.com> <1379575763-2091-6-git-send-email-Bharat.Bhushan@freescale.com> <1380127227.3030.316.camel@ul30vt.home> <6A3DF150A5B70D4F9B66A25E3F7C888D07183CA4@039-SN2MPN1-011.039d.mgd.msft.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginatorOrg: freescale.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2232 Lines: 54 On Wed, 2013-09-25 at 22:53 -0500, Bhushan Bharat-R65777 wrote: > > > -----Original Message----- > > From: Alex Williamson [mailto:alex.williamson@redhat.com] > > Sent: Wednesday, September 25, 2013 10:10 PM > > To: Bhushan Bharat-R65777 > > Cc: joro@8bytes.org; benh@kernel.crashing.org; galak@kernel.crashing.org; linux- > > kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- > > pci@vger.kernel.org; agraf@suse.de; Wood Scott-B07421; iommu@lists.linux- > > foundation.org; Bhushan Bharat-R65777 > > Subject: Re: [PATCH 5/7] iommu: supress loff_t compilation error on powerpc > > > > On Thu, 2013-09-19 at 12:59 +0530, Bharat Bhushan wrote: > > > Signed-off-by: Bharat Bhushan > > > --- > > > drivers/vfio/pci/vfio_pci_rdwr.c | 3 ++- > > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/vfio/pci/vfio_pci_rdwr.c > > > b/drivers/vfio/pci/vfio_pci_rdwr.c > > > index 210db24..8a8156a 100644 > > > --- a/drivers/vfio/pci/vfio_pci_rdwr.c > > > +++ b/drivers/vfio/pci/vfio_pci_rdwr.c > > > @@ -181,7 +181,8 @@ ssize_t vfio_pci_vga_rw(struct vfio_pci_device *vdev, char > > __user *buf, > > > size_t count, loff_t *ppos, bool iswrite) { > > > int ret; > > > - loff_t off, pos = *ppos & VFIO_PCI_OFFSET_MASK; > > > + loff_t off; > > > + u64 pos = (u64 )(*ppos & VFIO_PCI_OFFSET_MASK); > > > void __iomem *iomem = NULL; > > > unsigned int rsrc; > > > bool is_ioport; > > > > What's the compile error that this fixes? > > I was getting below error; and after some googling I came to know that this is how it is fixed by other guys. > > /home/r65777/linux-vfio/drivers/vfio/pci/vfio_pci_rdwr.c:193: undefined reference to `__cmpdi2' > /home/r65777/linux-vfio/drivers/vfio/pci/vfio_pci_rdwr.c:193: undefined reference to `__cmpdi2' It looks like PPC Linux implements __ucmpdi2, but not the signed version. That should be fixed, rather than hacking up random code to avoid it. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/