Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751251Ab3I0APV (ORCPT ); Thu, 26 Sep 2013 20:15:21 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:37789 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764Ab3I0APT convert rfc822-to-8bit (ORCPT ); Thu, 26 Sep 2013 20:15:19 -0400 From: "Rafael J. Wysocki" To: =?ISO-8859-1?Q?J=F6rg?= Otte Cc: Jani Nikula , Aaron Lu , Igor Gnatenko , ACPI Devel Maling List , intel-gfx , dri-devel@lists.freedesktop.org, Linux Kernel Mailing List , Daniel Vetter , Matthew Garrett , Seth Forshee , Lee Chun-Yi , Richard Purdie , Yves-Alexis Perez , Felipe Contreras , Henrique de Moraes Holschuh , Ben Jencks , Steven Newbury , James Hogan , Kamal Mostafa , Joerg Platte , Kalle Valo , Martin Steigerwald , Mike Galbraith Subject: Re: [PATCH v3 0/4] Fix Win8 backlight issue Date: Fri, 27 Sep 2013 02:26:35 +0200 Message-ID: <3910636.aGHp6YakQl@vostro.rjw.lan> User-Agent: KMail/4.10.5 (Linux/3.11.0+; KDE/4.10.5; x86_64; ; ) In-Reply-To: References: <1380016052-15315-1-git-send-email-aaron.lu@intel.com> <87eh8clvun.fsf@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2703 Lines: 67 On Thursday, September 26, 2013 09:49:03 AM Jörg Otte wrote: > 2013/9/25 Jani Nikula : > > On Wed, 25 Sep 2013, Jörg Otte wrote: > >> 2013/9/25 Jani Nikula : > >>> On Wed, 25 Sep 2013, Aaron Lu wrote: > >>>> On Wed, Sep 25, 2013 at 10:29:37AM +0200, Jörg Otte wrote: > >>>>> Backlight can't be modified with this patch set - neither with > >>>>> function keys nor with the gui. It is a step backward to v3.11-rc1 > >>> > >>> So both hotkeys and GUI work in v3.11-rc1? And v3.12-rc2? > >> > >> In v3.11-rc1 it didn't work. > >> Since a later rc (I don't remember exactly which) it did work. > >> In v3.12-rc1/2 it does work. > >> In v3.12-rc2 + Aaron's patch set it again doesn't work. > >> > >>> > >>>> Thanks for the test. > >>>> > >>>> Please check /sys/class/backlight, is there only one link file > >>>> intel_backlight? > >>> > >>> Indeed, are there others? fujitsu-laptop perhaps? If yes, try > >>> CONFIG_FUJITSU_LAPTOP=n or an appropriate module blacklist. > >>> > >>> Just checking, you do have CONFIG_BACKLIGHT_CLASS_DEVICE=y? > >> > >> There is only one intel_backlight link. > >> Yes, I have CONFIG_BACKLIGHT_CLASS_DEVICE=y > >> > >>> Embarrassingly there was a bug in i915 fixed just recently where the > >>> backlight device wasn't registered for > >>> CONFIG_BACKLIGHT_CLASS_DEVICE=m... > >>> > >>>> If so, please cd inside and try modify the brightness file using echo > >>>> with some values in the range of 0 - max_brightness, does the > >>>> backlight level change when you echo a new value? I guess it doesn't, > >>>> or you wouldn't notice problem. If indeed so, perhaps file a bug at > >>>> http://bugzilla.kernel.org, Drivers/Video(DRI-Intel)? I suppose Jani > >>>> and Daniel can help fix your problem. > >>> > >>> Yup, please check the above, and report back. > >> > >> - echo 0..max_brightness > brightness does not work. > > > > Thanks for the info. > > > > How about v3.12-rc2 without Aaron's patches? Does intel_backlight also > > not work there? How about the acpi_video0 (which I presume is present) > > sysfs interface? > > > > Without Aaron's patches intel_backlight also does not work. > But acpi_video0 does (and takes precedence I think). So can you please open a bug entry at bugzilla.kernel.org against i915? The fact that ACPI video works for you doesn't mean that intel_backlight shouldn't, I suppose? Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/