Date: Fri, 27 Sep 2013 07:51:51 +0200
From: Ingo Molnar <mingo@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Davidlohr Bueso <davidlohr@hp.com>, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, msharbiani@twitter.com,
        linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/reboot] x86/reboot: Remove the duplicate C6100 entry in
 the reboot quirks list
Message-ID: <20130927055151.GD6597@gmail.com>
References: <1380216643-4683-1-git-send-email-masoud.sharbiani@gmail.com>
 <tip-b5eafc6f07c95e9f3dd047e72737449cb03c9956@git.kernel.org>
 <1380229154.2170.13.camel@buesod1.americas.hpqcorp.net>
 <5244A0E2.3080902@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5244A0E2.3080902@zytor.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1070
Lines: 34


* H. Peter Anvin <hpa@zytor.com> wrote:

> On 09/26/2013 01:59 PM, Davidlohr Bueso wrote:
> >> -	},
> >> -	{	/* Some C6100 machines were shipped with vendor being 'Dell'. */
> >> -		.callback = set_pci_reboot,
> >> -		.ident = "Dell PowerEdge C6100",
> >> -		.matches = {
> >>  			DMI_MATCH(DMI_SYS_VENDOR, "Dell"),
> >>  			DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
> >>  		},
> > 
> > Hmm, I think we should be keeping the 'Dell Inc.' part instead of just
> > 'Dell' - at least the rest of the entries use the same string:
> > 
> 
> The point is that some of the machines just has "Dell" in their vendor
> string.

Yes, so if then the argument could be made that all the other entries 
should probably be changed to 'Dell' as well.

This is yet another reminder that DMI matches are such a fragile method 
...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/