Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753332Ab3I0Ihs (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 Sep 2013 04:37:48 -0400
Received: from moutng.kundenserver.de ([212.227.126.186]:65473 "EHLO
	moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751548Ab3I0Ihl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 Sep 2013 04:37:41 -0400
Date: Fri, 27 Sep 2013 10:37:37 +0200 (CEST)
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
X-X-Sender: lyakh@axis700.grange
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
cc: linux-kernel@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
        linux-sh@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH v2 5/5] ARM: shmobile: lager: (DEVEL) add CPUFreq support
In-Reply-To: <52447B9A.5090805@cogentembedded.com>
Message-ID: <Pine.LNX.4.64.1309271033270.23205@axis700.grange>
References: <1380216060-14506-1-git-send-email-g.liakhovetski@gmx.de>
 <1380216060-14506-6-git-send-email-g.liakhovetski@gmx.de>
 <52447B9A.5090805@cogentembedded.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Provags-ID: V02:K0:/D8oPxJYFgrlrO0xt5+QJ3a3FQoBRwT2OPqHh7jvJfN
 E4RG968rm4I+bQuRP/5NQG5PROMUpU2VzylaTggPglz4I2rXhm
 GUvZ0mSXkrF96GxvH0Xans2W5/a4O+c2BvF8gVQHSuTk80Thma
 JNFRYECK84nTOV7uBxVxqBh0MAG6EQs7BF9cvptej0Z6mIV9L4
 0TNS9GoZvV7ztPf5mgMZCoatF+rjgK6J/qmpyofDVSD1CqyvCs
 ogKlw2YhdYO1f6aet2BN3QCd2gCKqgzI+/ModTss0jzaWa+XVT
 5VtAz09oIxKf1v+aBTJMj2Xx9rfZJ6E2w5JlXJMeR8egPChsGV
 CSiGZWJgE8USDqaSFoElVoOMOe9RgkpvzuM4i2jNRljHxxFyN0
 BYooSGXzib8Zg==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3234
Lines: 102

Hi Sergei

On Thu, 26 Sep 2013, Sergei Shtylyov wrote:

> Hello.
> 
> On 09/26/2013 09:21 PM, Guennadi Liakhovetski wrote:
> 
> > The Lager board uses a DA9210 voltage regulator to supply DVFS power to the
> > CA15 cores on the r8a7790 SoC. This patch adds CPUFreq support for that
> > board using the cpufreq-cpu0 driver.
> 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > ---
> 
> > v2: added 'status = "okay";' to the i2c bus
> 
> >   arch/arm/boot/dts/r8a7790-lager-reference.dts  |   33
> > ++++++++++++++++++++++++
> >   arch/arm/mach-shmobile/board-lager-reference.c |    4 ++-
> >   2 files changed, 36 insertions(+), 1 deletions(-)
> 
> > diff --git a/arch/arm/boot/dts/r8a7790-lager-reference.dts
> > b/arch/arm/boot/dts/r8a7790-lager-reference.dts
> > index c462ef1..1ce0a97 100644
> > --- a/arch/arm/boot/dts/r8a7790-lager-reference.dts
> > +++ b/arch/arm/boot/dts/r8a7790-lager-reference.dts
> > @@ -43,3 +43,36 @@
> >   		};
> >   	};
> >   };
> > +
> > +&i2c3 {
> > +	status = "okay";
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&i2c3_pins>;
> > +
> > +	vdd_dvfs: da9210@68 {
> 
>   ePAPR spec [1] says: "The name of a node should be somewhat generic,
> reflecting the function of the device and not its precise programming model."

Sure, but I think it is common in Linux .dts files for I2C devices to use 
"<model>@<i2c addr>" as a name.

> So I suggest "regulator" instead of "da9210".
> 
> > +		compatible = "diasemi,da9210";
> > +		reg = <0x68>;
> > +
> > +		regulator-min-microvolt = <900000>;
> > +		regulator-max-microvolt = <1000000>;
> > +		regulator-boot-on;
> > +		regulator-always-on;
> > +	};
> > +};
> [...]
> > diff --git a/arch/arm/mach-shmobile/board-lager-reference.c
> > b/arch/arm/mach-shmobile/board-lager-reference.c
> > index 1a1a4a8..2bc8bae 100644
> > --- a/arch/arm/mach-shmobile/board-lager-reference.c
> > +++ b/arch/arm/mach-shmobile/board-lager-reference.c
> [...]
> > @@ -29,7 +30,8 @@ static void __init lager_add_standard_devices(void)
> >   	r8a7790_clock_init();
> > 
> >   	r8a7790_add_dt_devices();
> > -        of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> > +	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> 
>    Hm, "drove-by" cleanup?

This should be avoided in general, but this kind of stuff really doesn't 
deserve neither a separate patch nor a mention. Don't waste your precious 
brain cycles.

> > +	platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0);
> >   }
> > 
> >   static const char *lager_boards_compat_dt[] __initdata = {
> 
>    Shouldn't the patch be split into .dts and .c parts, I wonder?

Simon didn't complain, but perhaps it should, yes. I think I'll resubmit 
this as 2 patches with no changes.

Thanks
Guennadi

> [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
> 
> WBR, Sergei

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/