Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753002Ab3I0Izu (ORCPT ); Fri, 27 Sep 2013 04:55:50 -0400 Received: from mail-vb0-f51.google.com ([209.85.212.51]:60843 "EHLO mail-vb0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940Ab3I0Izs (ORCPT ); Fri, 27 Sep 2013 04:55:48 -0400 MIME-Version: 1.0 In-Reply-To: References: <1380207292-16968-1-git-send-email-ulf.hansson@linaro.org> <1380207292-16968-10-git-send-email-ulf.hansson@linaro.org> Date: Fri, 27 Sep 2013 10:55:47 +0200 Message-ID: Subject: Re: [PATCH 09/27] mmc: mvsdio: Remove redundant suspend and resume callbacks From: Ulf Hansson To: Nicolas Pitre Cc: "linux-kernel@vger.kernel.org" , linux-mmc , Chris Ball , Thomas Petazzoni , Jason Cooper , Andrew Lunn Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1210 Lines: 34 On 26 September 2013 17:40, Nicolas Pitre wrote: > On Thu, 26 Sep 2013, Ulf Hansson wrote: > >> Suspend and resume of cards are handled by the protocol layer and >> consequently the mmc_suspend|resume_host APIs are marked as deprecated. > > Having the protocol layer take care of card suspend is perfectly sound. > > However, what about host controllers? Shouldn't they suspend themselves > as well? There is certainly potential for power saving by gating clocks > to the host IP block or the like. > Hi Nicolas, You are right, host drivers shall be responsible to handle power saving operations, like clocks, power domains, pinctrls, etc. In many cases I think using only runtime PM should satisfy a host driver's need to perform the proper power saving. For mvsdio, there were no host power save operations done in the suspend/resume callbacks, which is why I removed the callbacks entirely. Kind regards Ulf Hansson > > Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/