Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751439Ab3I0K5J (ORCPT ); Fri, 27 Sep 2013 06:57:09 -0400 Received: from mga02.intel.com ([134.134.136.20]:58761 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949Ab3I0K5H (ORCPT ); Fri, 27 Sep 2013 06:57:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.90,991,1371106800"; d="scan'208";a="384353488" Date: Fri, 27 Sep 2013 14:02:27 +0300 From: Mika Westerberg To: Aaron Lu Cc: linux-acpi@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , "Rafael J. Wysocki" , Matthew Garrett , Seth Forshee , Lee Chun-Yi , Richard Purdie , Igor Gnatenko , Yves-Alexis Perez , Felipe Contreras , Henrique de Moraes Holschuh , Jani Nikula , Ben Jencks , Steven Newbury , James Hogan , Kamal Mostafa , Joerg Platte , Kalle Valo , Martin Steigerwald , =?iso-8859-1?Q?J=F6rg?= Otte , Mike Galbraith Subject: Re: [PATCH v3 0/4] Fix Win8 backlight issue Message-ID: <20130927110227.GD28875@intel.com> References: <1380016052-15315-1-git-send-email-aaron.lu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1380016052-15315-1-git-send-email-aaron.lu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2442 Lines: 54 On Tue, Sep 24, 2013 at 05:47:28PM +0800, Aaron Lu wrote: > v3: > 1 Add a new patch 4/4 to fix some problems in thinkpad-acpi module; > 2 Remove unnecessary function acpi_video_unregister introduced in > patch 2/3 as pointed out by Jani Nikula. > > v2: > v1 has the subject of "Rework ACPI video driver" and is posted here: > http://lkml.org/lkml/2013/9/9/74 > Since the objective is really to fix Win8 backlight issues, I changed > the subject in this version, sorry about that. > > This patchset has three patches, the first introduced a new API named > backlight_device_registered in backlight layer that can be used for > backlight interface provider module to check if a specific type backlight > interface has been registered, see changelog for patch 1/3 for details. > Then patch 2/3 does the cleanup to sepeate the backlight control and > event delivery functionality in the ACPI video module and patch 3/3 > solves some Win8 backlight control problems by avoiding register ACPI > video's backlight interface if: > 1 Kernel cmdline option acpi_backlight=video is not given; > 2 This is a Win8 system; > 3 Native backlight control interface exists. > > Technically, patch 2/3 is not required to fix the issue here. So if you > think it is not necessary, I can remove it from the series. > > Aaron Lu (4): > backlight: introduce backlight_device_registered > ACPI / video: seperate backlight control and event interface > ACPI / video: Do not register backlight if win8 and native interface > exists > thinkpad-acpi: fix handle locate for video and query of _BCL > > drivers/acpi/internal.h | 5 +- > drivers/acpi/video.c | 442 ++++++++++++++++++++--------------- > drivers/acpi/video_detect.c | 14 +- > drivers/platform/x86/thinkpad_acpi.c | 31 ++- > drivers/video/backlight/backlight.c | 31 +++ > include/acpi/video.h | 2 + > include/linux/backlight.h | 4 + > 7 files changed, 324 insertions(+), 205 deletions(-) Just tested this series on my HP revolve 810 and this fixes the backlight issue it had :) Feel free to add my, Tested-by: Mika Westerberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/