Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753045Ab3I0P2U (ORCPT ); Fri, 27 Sep 2013 11:28:20 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:29741 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155Ab3I0P2P (ORCPT ); Fri, 27 Sep 2013 11:28:15 -0400 Date: Fri, 27 Sep 2013 18:24:12 +0300 From: Dan Carpenter To: Joseph Salisbury Cc: Jiri Kosina , list@osuosl.org, Haiyang Zhang , LKML , open@osuosl.org, HID CORE LAYER , devel@linuxdriverproject.org, thomas@m3y3r.de Subject: Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup Message-ID: <20130927152412.GF6192@mwanda> References: <5237430B.5040009@canonical.com> <20130916203824.GP25896@mwanda> <52376ED9.5080208@canonical.com> <20130916210503.GQ25896@mwanda> <5237A5D5.8010006@canonical.com> <52432152.3030100@canonical.com> <52459942.3020600@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52459942.3020600@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1438 Lines: 44 On Fri, Sep 27, 2013 at 10:42:10AM -0400, Joseph Salisbury wrote: > On 09/27/2013 06:50 AM, Jiri Kosina wrote: > > On Wed, 25 Sep 2013, Joseph Salisbury wrote: > > > >> After further testing reverting the following commit does in fact > >> resolve the bug: > >> > >> commit b1a1442a23776756b254b69786848a94d92445ba > >> Author: Jiri Kosina > >> Date: Mon Jun 3 11:27:48 2013 +0200 > >> > >> HID: core: fix reporting of raw events > >> > >> Reverting this commit in v3.12-rc2 prevents the system from locking up, > >> which happens when connecting a bluetooth trackpad. > >> > >> Jiri, do you think we should revert this patch, or is there some further > >> debugging/data collecting you would like to do? > > Hi Joseph, > > > > in this mail: > > > > Message-ID: <5241992E.3090805@canonical.com> > > Date: Tue, 24 Sep 2013 09:52:46 -0400 > > > > you said that reverting this commit doesn't prevent the lockups, so I am > > rather confused ... ? > > > > Thanks, > > > The testing was invalid. Reverting commit b1a1442 does resolve the bug > and stop the lockups. > It looks like magicmouse_raw_event() returns 1 on success and 0 on failure. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/