Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753609Ab3I0QVI (ORCPT ); Fri, 27 Sep 2013 12:21:08 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:36951 "EHLO mail-we0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752475Ab3I0QVG (ORCPT ); Fri, 27 Sep 2013 12:21:06 -0400 MIME-Version: 1.0 In-Reply-To: <20130926063453.GA526@polaris.bitmath.org> References: <20130925195628.GA1532@roeck-us.net> <20130925214807.GA3234@polaris.bitmath.org> <20130925220838.GB4184@roeck-us.net> <20130926063453.GA526@polaris.bitmath.org> Date: Fri, 27 Sep 2013 12:21:04 -0400 X-Google-Sender-Auth: 1Xqe6ZKOF68gx6WgDKi6lMCGI4c Message-ID: Subject: Re: applesmc oops in 3.10/3.11 From: Josh Boyer To: Henrik Rydberg Cc: Guenter Roeck , khali@linux-fr.org, lm-sensors@lm-sensors.org, "Linux-Kernel@Vger. Kernel. Org" , bugzilla@colorremedies.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2153 Lines: 54 On Thu, Sep 26, 2013 at 2:34 AM, Henrik Rydberg wrote: >> > > This suggests that initialization may be attempted more than once. The key cache >> > > is allocated only once, but the number of keys is read for each attempt. >> > > >> > > No idea if that can happen, but if the number of keys can increase after >> > > the first initialization attempt you would have an explanation for the crash. >> > >> > Good idea, and easy enough to test with the patch below. >> > >> Should we apply this patch even though it may not solve the specific problem ? > > Yes, why not - it certainly won't hurt. I am running it right now, so > it is at least run-tested. > >> Again, not sure if the key count can change, but the current code is at the very >> least inconsistent, as it keeps reading the key count without updating or >> verifying the cache size. > > Yes - I agree that the error state is far-fetched, but it is hard to > see any other logical explanation. There is of course always the > possibility that the problem is somewhere else completely. > > Proper patch attached. > > Thanks, > Henrik > > --- > > From dedefba9167913c46e1896ce0624e68ffe95d532 Mon Sep 17 00:00:00 2001 > From: Henrik Rydberg > Date: Thu, 26 Sep 2013 08:33:16 +0200 > Subject: [PATCH] hwmon: (applesmc) Check key count before proceeding > > After reports from Chris and Josh Boyer of a rare crash in applesmc, > Guenter pointed at the initialization problem fixed below. The patch > has not been verified to fix the crash, but should be applied > regardless. > > Reported-by: > Suggested-by: Guenter Roeck > Signed-off-by: Henrik Rydberg > --- > drivers/hwmon/applesmc.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Thanks for the quick reply. I'll get this rolled into our kernels soon. josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/