Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753643Ab3I0QVz (ORCPT ); Fri, 27 Sep 2013 12:21:55 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:51824 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751719Ab3I0QVy (ORCPT ); Fri, 27 Sep 2013 12:21:54 -0400 Message-ID: <5245B076.1090008@ti.com> Date: Fri, 27 Sep 2013 11:21:10 -0500 From: Suman Anna User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Kumar Gala CC: Ohad Ben-Cohen , Tony Lindgren , Benoit Cousson , Paul Walmsley , , , Subject: Re: [PATCHv2 2/9] hwspinlock/omap: add support for dt nodes References: <0fd6a11880894260d627a50b1e35f363625e9b1d.1379445653.git.s-anna@ti.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2775 Lines: 60 On 09/27/2013 11:06 AM, Kumar Gala wrote: > > On Sep 17, 2013, at 2:30 PM, Suman Anna wrote: > >> HwSpinlock IP is present only on OMAP4 and other newer SoCs, >> which are all device-tree boot only. This patch adds the >> base support for parsing the DT nodes, and removes the code >> dealing with the traditional platform device instantiation. >> >> Signed-off-by: Suman Anna >> --- >> .../devicetree/bindings/hwlock/omap-hwspinlock.txt | 31 +++++++++++ >> arch/arm/mach-omap2/Makefile | 3 -- >> arch/arm/mach-omap2/hwspinlock.c | 60 ---------------------- >> drivers/hwspinlock/omap_hwspinlock.c | 23 +++++++-- >> 4 files changed, 50 insertions(+), 67 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/hwlock/omap-hwspinlock.txt >> delete mode 100644 arch/arm/mach-omap2/hwspinlock.c >> >> diff --git a/Documentation/devicetree/bindings/hwlock/omap-hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/omap-hwspinlock.txt >> new file mode 100644 >> index 0000000..235b7c5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwlock/omap-hwspinlock.txt >> @@ -0,0 +1,31 @@ >> +OMAP4+ HwSpinlock Driver >> +======================== >> + >> +Required properties: >> +- compatible: Currently supports only "ti,omap4-hwspinlock" for >> + OMAP44xx, OMAP54xx, AM33xx, AM43xx, DRA7xx SoCs >> +- reg: Contains the hwspinlock register address range (base >> + address and length) >> +- ti,hwmods: Name of the hwmod associated with the hwspinlock device >> + >> +Common hwlock properties: >> +The following describes the usage of the common hwlock properties (defined in >> +Documentation/devicetree/bindings/hwlock/hwlock.txt) on OMAP. >> + >> +- hwlock-base-id: There are currently no OMAP SoCs with multiple >> + hwspinlock devices. The OMAP driver uses a default >> + base id value of 0 for the locks present within the >> + single hwspinlock device on all SoCs. >> +- hwlock-num-locks: This property is not required on OMAP SoCs, since the >> + number of locks present within a device can be deduced >> + from the SPINLOCK_SYSSTATUS device register. > > If you are going to be explicit about this properties, you should probably be a bit more clear about them NOT being in the OMAP dts because of the reasons you specify. You mean on the hwlock-base-id? I wanted to document how these properties (do not) apply for OMAP, I will revise the text to be a bit more explicit. Thanks for the review. regards Suman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/