Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754561Ab3I0SrI (ORCPT ); Fri, 27 Sep 2013 14:47:08 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:46873 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754125Ab3I0SrF (ORCPT ); Fri, 27 Sep 2013 14:47:05 -0400 Message-ID: <5245D27C.8080901@ti.com> Date: Sat, 28 Sep 2013 00:16:20 +0530 From: George Cherian User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Javier Martinez Canillas CC: Stephen Warren , Santosh Shilimkar , Kevin Hilman , Linus Walleij , Lars Poeschel , Grant Likely , Mark Rutland , Ian Campbell , Kumar Gala , Pawel Moll , Tomasz Figa , Enric Balletbo i Serra , Jean-Christophe PLAGNIOL-VILLARD , Balaji T K , Tony Lindgren , Jon Hunter , , , , , , , , Paul Walmsley , Subject: Re: [RFC v2] gpio/omap: auto-setup a GPIO when used as an IRQ References: <1380009480-4975-1-git-send-email-javier.martinez@collabora.co.uk> <5244C0C4.2030004@wwwdotorg.org> <52453545.3090504@collabora.co.uk> In-Reply-To: <52453545.3090504@collabora.co.uk> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2619 Lines: 62 On 9/27/2013 1:05 PM, Javier Martinez Canillas wrote: > On 09/27/2013 01:18 AM, Stephen Warren wrote: >> On 09/24/2013 01:58 AM, Javier Martinez Canillas wrote: >>> The OMAP GPIO controller HW requires a pin to be configured in GPIO >>> input mode in order to operate as an interrupt input. Since drivers >>> should not be aware of whether an interrupt pin is also a GPIO or not, >>> the HW should be fully configured/enabled as an IRQ if a driver solely >>> uses IRQ APIs such as request_irq(), and never calls any GPIO-related >>> APIs. As such, add the missing HW setup to the OMAP GPIO controller's >>> irq_chip driver. >>> >>> Since this bypasses the GPIO subsystem we have to ensure that another >>> caller won't be able to request the same GPIO pin that is used as an >>> IRQ and set its direction as output. Requesting the GPIO and setting >>> its direction as input is allowed though. >> FWIW, the concept of this patch, >> Acked-by: Stephen Warren >> >> I didn't review the code; just skimmed it to see where the new >> functionality was implemented. >> > Thanks Stephen, > > I split the changes as suggested by Tony and posted as a patch-set and not an > RFC anymore: > > [PATCH 1/2] gpio/omap: maintain GPIO and IRQ usage separately [1] > [PATCH 2/2] gpio/omap: auto-setup a GPIO when used as an IRQ [2] > > Linus, > > Could you please add Stephen Acked-by when taking the patches and also George > Cherian Tested-by that sent for this RFC. George it would be great if you can > also comment on which OMAP platform you had tested. Tested on dra7xx/evm with GPIO interrupt for pcf gpio expander. Tested-by: George Cherian > > I cc'ed Aaro Koskinen and Paul Walmsley now which seems to have OMAP1 platforms > to test. Could you please test [1] and [2] on a OMAP1 board? These patches > solves a long standing issue we have on OMAP2+ when booting with DT and it would > be great if you can check that it does not cause regressions on OMAP1 based boards. > > Thanks a lot and best regards, > Javier > > [1]: https://patchwork.kernel.org/patch/2937351/ > [2]: https://patchwork.kernel.org/patch/2937371/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- -George -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/