Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754772Ab3I0VyI (ORCPT ); Fri, 27 Sep 2013 17:54:08 -0400 Received: from mail-ie0-f170.google.com ([209.85.223.170]:46676 "EHLO mail-ie0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754534Ab3I0VyE (ORCPT ); Fri, 27 Sep 2013 17:54:04 -0400 MIME-Version: 1.0 In-Reply-To: <1380318405.27811.37.camel@pasglop> References: <1380270519.27811.10.camel@pasglop> <1380318405.27811.37.camel@pasglop> Date: Fri, 27 Sep 2013 14:54:02 -0700 X-Google-Sender-Auth: K-ksvBO15vT5YxmVnDJci8vCtVM Message-ID: Subject: Re: Please revert 928bea964827d7824b548c1f8e06eccbbc4d0d7d From: Yinghai Lu To: Benjamin Herrenschmidt Cc: Linus Torvalds , Bjorn Helgaas , "linux-pci@vger.kernel.org" , linuxppc-dev , Linux Kernel list Content-Type: multipart/mixed; boundary=089e0149c10c4e0b6604e76486c7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1601 Lines: 33 --089e0149c10c4e0b6604e76486c7 Content-Type: text/plain; charset=ISO-8859-1 On Fri, Sep 27, 2013 at 2:46 PM, Benjamin Herrenschmidt wrote: > Wouldn't it be better to simply have pci_enable_device() always set bus > master on a bridge? I don't see any case where it makes sense to have > an enabled bridge without the master bit set on it... Do you mean attached? --089e0149c10c4e0b6604e76486c7 Content-Type: application/octet-stream; name="pci_set_master_again.patch" Content-Disposition: attachment; filename="pci_set_master_again.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hm3y6pzm0 ZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL3BjaS5jIGIvZHJpdmVycy9wY2kvcGNpLmMKaW5kZXgg ZThjY2Y2Yy4uNGVmZjk5YiAxMDA2NDQKLS0tIGEvZHJpdmVycy9wY2kvcGNpLmMKKysrIGIvZHJp dmVycy9wY2kvcGNpLmMKQEAgLTExNTYsMTEgKzExNTYsMTMgQEAgc3RhdGljIHZvaWQgcGNpX2Vu YWJsZV9icmlkZ2Uoc3RydWN0IHBjaV9kZXYgKmRldikKIAlwY2lfZW5hYmxlX2JyaWRnZShkZXYt PmJ1cy0+c2VsZik7CiAKIAlpZiAocGNpX2lzX2VuYWJsZWQoZGV2KSkKLQkJcmV0dXJuOworCQln b3RvIG91dDsgLyogc29tZSBvdGhlciBkcml2ZXIgY291bGQgc2tpcCBwY2lfc2V0X21hc3RlciAh ICovCiAJcmV0dmFsID0gcGNpX2VuYWJsZV9kZXZpY2UoZGV2KTsKIAlpZiAocmV0dmFsKQogCQlk ZXZfZXJyKCZkZXYtPmRldiwgIkVycm9yIGVuYWJsaW5nIGJyaWRnZSAoJWQpLCBjb250aW51aW5n XG4iLAogCQkJcmV0dmFsKTsKKworb3V0OgogCXBjaV9zZXRfbWFzdGVyKGRldik7CiB9CiAK --089e0149c10c4e0b6604e76486c7-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/