Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754740Ab3I0WAV (ORCPT ); Fri, 27 Sep 2013 18:00:21 -0400 Received: from gate.crashing.org ([63.228.1.57]:34665 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754559Ab3I0WAS (ORCPT ); Fri, 27 Sep 2013 18:00:18 -0400 Message-ID: <1380319203.27811.44.camel@pasglop> Subject: Re: Please revert 928bea964827d7824b548c1f8e06eccbbc4d0d7d From: Benjamin Herrenschmidt To: Yinghai Lu Cc: Linus Torvalds , Bjorn Helgaas , "linux-pci@vger.kernel.org" , linuxppc-dev , Linux Kernel list Date: Sat, 28 Sep 2013 08:00:03 +1000 In-Reply-To: References: <1380270519.27811.10.camel@pasglop> <1380318405.27811.37.camel@pasglop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 26 On Fri, 2013-09-27 at 14:54 -0700, Yinghai Lu wrote: > On Fri, Sep 27, 2013 at 2:46 PM, Benjamin Herrenschmidt > wrote: > > > Wouldn't it be better to simply have pci_enable_device() always set bus > > master on a bridge? I don't see any case where it makes sense to have > > an enabled bridge without the master bit set on it... > > Do you mean attached? That's an option. I was thinking making pci_enable_device() itself enable bus master on a bridge but yes, you approach should work. I'm digging a bit more to figure out what went wrong in the pcie port driver since that's interesting in its own right and I'll then test your patch which I think is a more robust approach. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/