Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754776Ab3I0WiX (ORCPT ); Fri, 27 Sep 2013 18:38:23 -0400 Received: from gate.crashing.org ([63.228.1.57]:49039 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753419Ab3I0WiV (ORCPT ); Fri, 27 Sep 2013 18:38:21 -0400 Message-ID: <1380321480.27811.53.camel@pasglop> Subject: Re: Please revert 928bea964827d7824b548c1f8e06eccbbc4d0d7d From: Benjamin Herrenschmidt To: Yinghai Lu Cc: Linus Torvalds , Bjorn Helgaas , "linux-pci@vger.kernel.org" , linuxppc-dev , Linux Kernel list Date: Sat, 28 Sep 2013 08:38:00 +1000 In-Reply-To: References: <1380270519.27811.10.camel@pasglop> <1380318405.27811.37.camel@pasglop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 26 On Fri, 2013-09-27 at 14:54 -0700, Yinghai Lu wrote: > On Fri, Sep 27, 2013 at 2:46 PM, Benjamin Herrenschmidt > wrote: > > > Wouldn't it be better to simply have pci_enable_device() always set bus > > master on a bridge? I don't see any case where it makes sense to have > > an enabled bridge without the master bit set on it... > > Do you mean attached? So this patch works and fixes the problem. I think it makes the whole thing more robust and should be applied. I still don't know why the bridge doesn't get enabled properly without it yes, tracking it down (the machine in question takes a LONG time to reboot :-) Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/