Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754710Ab3I1AON (ORCPT ); Fri, 27 Sep 2013 20:14:13 -0400 Received: from zene.cmpxchg.org ([85.214.230.12]:55919 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754204Ab3I1AOK (ORCPT ); Fri, 27 Sep 2013 20:14:10 -0400 Date: Fri, 27 Sep 2013 20:13:14 -0400 From: Johannes Weiner To: "Kirill A. Shutemov" Cc: Cody P Schafer , Alex Thorlton , Ingo Molnar , Andrew Morton , Naoya Horiguchi , "Eric W . Biederman" , "Paul E . McKenney" , Al Viro , Andi Kleen , Andrea Arcangeli , Dave Hansen , Dave Jones , David Howells , Frederic Weisbecker , Kees Cook , Mel Gorman , Michael Kerrisk , Oleg Nesterov , Peter Zijlstra , Rik van Riel , Robin Holt , Sedat Dilek , Srikar Dronamraju , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 02/10] mm: convert mm->nr_ptes to atomic_t Message-ID: <20130928001314.GQ856@cmpxchg.org> References: <1380287787-30252-1-git-send-email-kirill.shutemov@linux.intel.com> <1380287787-30252-3-git-send-email-kirill.shutemov@linux.intel.com> <5245EEAD.7010901@linux.vnet.ibm.com> <20130927222451.3406EE0090@blue.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130927222451.3406EE0090@blue.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2528 Lines: 58 On Sat, Sep 28, 2013 at 01:24:51AM +0300, Kirill A. Shutemov wrote: > Cody P Schafer wrote: > > On 09/27/2013 06:16 AM, Kirill A. Shutemov wrote: > > > With split page table lock for PMD level we can't hold > > > mm->page_table_lock while updating nr_ptes. > > > > > > Let's convert it to atomic_t to avoid races. > > > > > > > > --- > > > > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > > > index 84e0c56e1e..99f19e850d 100644 > > > --- a/include/linux/mm_types.h > > > +++ b/include/linux/mm_types.h > > > @@ -339,6 +339,7 @@ struct mm_struct { > > > pgd_t * pgd; > > > atomic_t mm_users; /* How many users with user space? */ > > > atomic_t mm_count; /* How many references to "struct mm_struct" (users count as 1) */ > > > + atomic_t nr_ptes; /* Page table pages */ > > > int map_count; /* number of VMAs */ > > > > > > spinlock_t page_table_lock; /* Protects page tables and some counters */ > > > @@ -360,7 +361,6 @@ struct mm_struct { > > > unsigned long exec_vm; /* VM_EXEC & ~VM_WRITE */ > > > unsigned long stack_vm; /* VM_GROWSUP/DOWN */ > > > unsigned long def_flags; > > > - unsigned long nr_ptes; /* Page table pages */ > > > unsigned long start_code, end_code, start_data, end_data; > > > unsigned long start_brk, brk, start_stack; > > > unsigned long arg_start, arg_end, env_start, env_end; > > > > Will 32bits always be enough here? Should atomic_long_t be used instead? > > Good question! > > On x86_64 we need one table to cover 2M (512 entries by 4k, 21 bits) of > virtual address space. Total size of virtual memory which can be covered > by 31-bit (32 - sign) nr_ptes is 52 bits (31 + 21). > > Currently, on x86_64 with 4-level page tables we can use at most 48 bit of > virtual address space (only half of it available for userspace), so we > pretty safe here. > > Although, it can be a potential problem, if (when) x86_64 will implement > 5-level page tables -- 57-bits of virtual address space. > > Any thoughts? I'd just go with atomic_long_t to avoid having to worry about this in the first place. It's been ulong forever and I'm not aware of struct mm_struct size being an urgent issue. Cutting this type in half and adding overflow checks adds more problems than it solves. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/