Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754170Ab3I1NsP (ORCPT ); Sat, 28 Sep 2013 09:48:15 -0400 Received: from mail-bk0-f51.google.com ([209.85.214.51]:44485 "EHLO mail-bk0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754036Ab3I1NsN (ORCPT ); Sat, 28 Sep 2013 09:48:13 -0400 MIME-Version: 1.0 In-Reply-To: <20130925184435.GH2954@lukather> References: <1379852488-32147-1-git-send-email-cinifr@gmail.com> <1379852488-32147-2-git-send-email-cinifr@gmail.com> <20130923181707.GR2779@lukather> <20130925184435.GH2954@lukather> Date: Sat, 28 Sep 2013 21:48:11 +0800 Message-ID: Subject: Re: [PATCH V3: Add Smp support for Allwinner A20. 1/3] Add smp support for Allwinner A20(sunxi 7i). From: cinifr To: Maxime Ripard Cc: coosty@163.com, Daniel Lezcano , "linux@arm.linux.org.uk" , "tglx@linutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Mark Rutland , "pawel.moll@arm.co" , Rob Herring , "linux-sunxi@googlegroups.com" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1347 Lines: 38 Hi Maxime, I have test it, but I found it does not work. If using smp_prepare_cpus, the kernenl cannot find the secondary cpus because that smp_prepare_cpus semms not be excuted before kernel is booting secondary cpus. So I have to use early_initcall. Fan. On 26 September 2013 02:44, Maxime Ripard wrote: > Hi Fan, > > On Wed, Sep 25, 2013 at 12:22:44AM +0800, cinifr wrote: >> > You still haven't said why you don't want to use smp_init_cpus there. >> I find that of_funcation liking of_find_matching_node and of_iomap can >> not run well in smp_init_cpus. It cause kernel crash. So I have to use >> early_initcall. > > Ah, right. > > Then, can't we use smp_prepare_cpus for this? it looks to be late enough > so that we can use ioremap there. > > I don't want it to be an initcall. The code will be different on the > A31, and we don't want it to be run on all the other machines whenever > we boot a multiplatform kernel anyway. > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/