Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443Ab3I2Etn (ORCPT ); Sun, 29 Sep 2013 00:49:43 -0400 Received: from mail-qc0-f179.google.com ([209.85.216.179]:38272 "EHLO mail-qc0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221Ab3I2Etk (ORCPT ); Sun, 29 Sep 2013 00:49:40 -0400 MIME-Version: 1.0 In-Reply-To: <5245CCBF.3070206@gmail.com> References: <1379526839-14798-1-git-send-email-sebastian.hesselbarth@gmail.com> <1379526839-14798-5-git-send-email-sebastian.hesselbarth@gmail.com> <523ABA7A.50305@gmail.com> <523EDEB0.1060601@gmail.com> <5245CCBF.3070206@gmail.com> From: Barry Song <21cnbao@gmail.com> Date: Sun, 29 Sep 2013 12:49:20 +0800 Message-ID: Subject: Re: [PATCH 04/26] clk: prima2: declare OF clock provider To: Sebastian Hesselbarth Cc: Mike Turquette , Arnd Bergmann , LKML , Barry Song , Olof Johansson , Russell King , "linux-arm-kernel@lists.infradead.org" , DL-SHA-WorkGroupLinux Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1676 Lines: 60 2013/9/28 Sebastian Hesselbarth : > On 09/22/2013 12:37 PM, Barry Song wrote: >> >> 2013/9/22 Sebastian Hesselbarth : >>> >>> On 09/19/2013 10:48 AM, Sebastian Hesselbarth wrote: >>>> >>>> >>>> On 09/19/13 10:45, Barry Song wrote: >>>>>> >>>>>> >>>>>> @@ -1124,3 +1106,4 @@ void __init sirfsoc_of_clk_init(void) >>>>>> >>>>>> of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data); >>>>>> } >>>>>> +CLK_OF_DECLARE(sirfsoc_clk, "sirf,prima2-clkc", sirfsoc_clk_init); >>>>> >>>>> >>>>> >>>>> hi Sebastian, >>>>> what if the driver is compatible with multiple clk controllers and we >>>>> want to add another compatible string here except "sirf,prima2-clkc"? >>>>> >>>>> -barry >>>>> >>>> >>>> Just add >>>> CLK_OF_DECLARE(other_fancy_clk, "sirf,different-compatible", >>>> sirfsoc_clk_init); >>> >>> >>> >>> Barry, BTW, do I get your Acked-By for this and the corresponding >>> removal patch? >> >> >> Sebastian, would you wait for a while as i need to merge them and make a >> test. > > > Sure, take your time. > I now have almost all Acked-by's for the other patches, would be > great if you find some time to test this on prima2 anytime soon. Acked-by: Barry Song i have another clock patchset:http://permalink.gmane.org/gmane.linux.ports.arm.kernel/268241 i will rebase mine against your this one. > > Sebastian -barry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/