Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753876Ab3I3IwI (ORCPT ); Mon, 30 Sep 2013 04:52:08 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53188 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752230Ab3I3IwG (ORCPT ); Mon, 30 Sep 2013 04:52:06 -0400 Date: Mon, 30 Sep 2013 10:52:00 +0200 (CEST) From: Jiri Kosina To: Greg KH Cc: Stefan Achatz , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: roccat: Fix "cannot create duplicate filename" problems In-Reply-To: <20130928040257.GA21630@kroah.com> Message-ID: References: <1380340666.2451.4.camel@neuromancer.tessier-ashpool> <20130928040257.GA21630@kroah.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1652 Lines: 45 On Fri, 27 Sep 2013, Greg KH wrote: > > Fixing some wrong macro stringification/concatenation. > > > > Cc: Greg Kroah-Hartman > > Signed-off-by: Stefan Achatz > > --- > > drivers/hid/hid-roccat-kone.c | 2 +- > > drivers/hid/hid-roccat-koneplus.c | 4 ++-- > > drivers/hid/hid-roccat-kovaplus.c | 4 ++-- > > drivers/hid/hid-roccat-pyra.c | 4 ++-- > > 4 files changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c > > index 602c188..6101816 100644 > > --- a/drivers/hid/hid-roccat-kone.c > > +++ b/drivers/hid/hid-roccat-kone.c > > @@ -382,7 +382,7 @@ static ssize_t kone_sysfs_write_profilex(struct file *fp, > > } > > #define PROFILE_ATTR(number) \ > > static struct bin_attribute bin_attr_profile##number = { \ > > - .attr = { .name = "profile##number", .mode = 0660 }, \ > > + .attr = { .name = "profile" #number, .mode = 0660 }, \ > > Ugh, very sorry about that, I hate macros in C at times :) > > Jiri, can you take this through your tree, or I can if you want, it > needs to go in for 3.12-final. > > If yours, feel free to add: > > Acked-by: Greg Kroah-Hartman > > Stefan, thanks for fixing my bugs, it's much appreciated. Thanks, queued, will go to Linus for 3.12 still. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/